Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove parentheses from Preview and Dev build #6418

Merged
4 commits merged into from
Jun 9, 2020
Merged

Remove parentheses from Preview and Dev build #6418

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e0956b4
Remove parentheses from Preview build
carlos-zamora Jun 8, 2020
f5ad5c2
also remove parens from Dev build
carlos-zamora Jun 8, 2020
5fdd403
address PR comments
carlos-zamora Jun 9, 2020
91b0cf8
let's not regress that UAC prompt bug.
carlos-zamora Jun 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/cascadia/CascadiaPackage/Package-Pre.appxmanifest
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
Version="0.5.0.0" />

<Properties>
<DisplayName>Windows Terminal (Preview)</DisplayName>
<DisplayName>ms-resource:AppNamePre</DisplayName>
carlos-zamora marked this conversation as resolved.
Show resolved Hide resolved
<PublisherDisplayName>Microsoft Corporation</PublisherDisplayName>
<Logo>Images\StoreLogo.png</Logo>
</Properties>
Expand Down
2 changes: 1 addition & 1 deletion src/cascadia/CascadiaPackage/Package.appxmanifest
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
Version="1.0.0.0" />

<Properties>
<DisplayName>Windows Terminal</DisplayName>
<DisplayName>ms-resource:AppName</DisplayName>
<PublisherDisplayName>Microsoft Corporation</PublisherDisplayName>
<Logo>Images\StoreLogo.png</Logo>
</Properties>
Expand Down
8 changes: 4 additions & 4 deletions src/cascadia/CascadiaPackage/Resources/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,18 +121,18 @@
<value>Windows Terminal</value>
</data>
<data name="AppNameDev" xml:space="preserve">
<value>Windows Terminal (Dev Build)</value>
<value>Windows Terminal Dev Build</value>
carlos-zamora marked this conversation as resolved.
Show resolved Hide resolved
</data>
<data name="AppNamePre" xml:space="preserve">
<value>Windows Terminal (Preview)</value>
<value>Windows Terminal Preview</value>
</data>
<data name="AppShortName" xml:space="preserve">
<value>Terminal</value>
</data>
<data name="AppShortNameDev" xml:space="preserve">
<value>Terminal (Dev)</value>
<value>Terminal Dev</value>
</data>
<data name="AppShortNamePre" xml:space="preserve">
<value>Terminal (Preview)</value>
<value>Terminal Preview</value>
</data>
</root>