microsoft · Jun 1, 2020 · May 27, 2020 · May 27, 2020 · May 27, 2020 · Jun 1, 2020
diff --git a/.github/actions/spell-check/dictionary/api.txt b/.github/actions/spell-check/dictionary/api.txt
diff --git a/.github/actions/spell-check/dictionary/apis.txt b/.github/actions/spell-check/dictionary/apis.txt
@@ -5,6 +5,7 @@ IBox
 ICustom
 IMap
 IObject
+IStorage
 LCID
 NCHITTEST
 NCLBUTTONDBLCLK

diff --git a/dep/wil b/dep/wil
diff --git a/src/buffer/out/CharRow.cpp b/src/buffer/out/CharRow.cpp
@@ -321,7 +321,7 @@ COORD CharRow::GetStorageKey(const size_t column) const noexcept
 // - Updates the pointer to the parent row (which might change if we shuffle the rows around)
 // Arguments:
 // - pParent - Pointer to the parent row
-void CharRow::UpdateParent(ROW* const pParent) noexcept
+void CharRow::UpdateParent(ROW* const pParent)
 {
     _pParent = FAIL_FAST_IF_NULL(pParent);
 }
diff --git a/src/buffer/out/CharRow.hpp b/src/buffer/out/CharRow.hpp
@@ -88,7 +88,7 @@ class CharRow final
     const UnicodeStorage& GetUnicodeStorage() const noexcept;
     COORD GetStorageKey(const size_t column) const noexcept;
 
-    void UpdateParent(ROW* const pParent) noexcept;
+    void UpdateParent(ROW* const pParent);
 
     friend CharRowCellReference;
     friend constexpr bool operator==(const CharRow& a, const CharRow& b) noexcept;

diff --git a/src/cascadia/PublicTerminalCore/HwndTerminal.cpp b/src/cascadia/PublicTerminalCore/HwndTerminal.cpp
@@ -29,6 +29,7 @@ LRESULT CALLBACK HwndTerminal::HwndTerminalWndProc(
     UINT uMsg,
     WPARAM wParam,
     LPARAM lParam) noexcept
+try
 {
 #pragma warning(suppress : 26490) // Win32 APIs can only store void*, have to use reinterpret_cast
     HwndTerminal* terminal = reinterpret_cast<HwndTerminal*>(GetWindowLongPtr(hwnd, GWLP_USERDATA));
@@ -84,6 +85,7 @@ LRESULT CALLBACK HwndTerminal::HwndTerminalWndProc(
     }
     return DefWindowProc(hwnd, uMsg, wParam, lParam);
 }
+CATCH_LOG()
 
 static bool RegisterTermClass(HINSTANCE hInstance) noexcept
 {
@@ -686,6 +688,7 @@ void __stdcall TerminalKillFocus(void* terminal)
 // - rows - Rows of text data to copy
 // - fAlsoCopyFormatting - true if the color and formatting should also be copied, false otherwise
 HRESULT HwndTerminal::_CopyTextToSystemClipboard(const TextBuffer::TextAndColor& rows, bool const fAlsoCopyFormatting)
+try
 {
     std::wstring finalString;
 
@@ -714,7 +717,7 @@ HRESULT HwndTerminal::_CopyTextToSystemClipboard(const TextBuffer::TextAndColor&
     RETURN_LAST_ERROR_IF(!OpenClipboard(_hwnd.get()));
 
     { // Clipboard Scope
-        auto clipboardCloser = wil::scope_exit([]() noexcept {
+        auto clipboardCloser = wil::scope_exit([]() {
             LOG_LAST_ERROR_IF(!CloseClipboard());
         });
 
@@ -742,6 +745,7 @@ HRESULT HwndTerminal::_CopyTextToSystemClipboard(const TextBuffer::TextAndColor&
 
     return S_OK;
 }
+CATCH_RETURN()
 
 // Routine Description:
 // - Copies the given string onto the global system clipboard in the specified format

diff --git a/src/cascadia/TerminalConnection/ConptyConnection.cpp b/src/cascadia/TerminalConnection/ConptyConnection.cpp
@@ -294,6 +294,7 @@ namespace winrt::Microsoft::Terminal::TerminalConnection::implementation
     // Method Description:
     // - called when the client application (not necessarily its pty) exits for any reason
     void ConptyConnection::_ClientTerminated() noexcept
+    try
     {
         if (_isStateAtOrBeyond(ConnectionState::Closing))
         {
@@ -321,6 +322,7 @@ namespace winrt::Microsoft::Terminal::TerminalConnection::implementation
 
         _piClient.reset();
     }
+    CATCH_LOG()
 
     void ConptyConnection::WriteInput(hstring const& data)
     {
@@ -349,6 +351,7 @@ namespace winrt::Microsoft::Terminal::TerminalConnection::implementation
     }
 
     void ConptyConnection::Close() noexcept
+    try
     {
         if (_transitionToState(ConnectionState::Closing))
         {
@@ -378,6 +381,7 @@ namespace winrt::Microsoft::Terminal::TerminalConnection::implementation
             _transitionToState(ConnectionState::Closed);
         }
     }
+    CATCH_LOG()
 
     DWORD ConptyConnection::_OutputThread()
     {

diff --git a/src/renderer/dx/DxRenderer.cpp b/src/renderer/dx/DxRenderer.cpp
@@ -2236,6 +2236,7 @@ void DxEngine::SetAntialiasingMode(const D2D1_TEXT_ANTIALIAS_MODE antialiasingMo
 // Return Value:
 // - <none>
 void DxEngine::SetDefaultTextBackgroundOpacity(const float opacity) noexcept
+try
 {
     _defaultTextBackgroundOpacity = opacity;
 
@@ -2244,3 +2245,4 @@ void DxEngine::SetDefaultTextBackgroundOpacity(const float opacity) noexcept
     // We don't terribly care if this fails.
     LOG_IF_FAILED(InvalidateAll());
 }
+CATCH_LOG()
-Original file line number
+Diff line change
@@ Expand Up / @@ -5,6 +5,7 @@ IBox @@
     ICustom
     IMap
     IObject
+    IStorage
     LCID
     NCHITTEST
     NCLBUTTONDBLCLK
@@ Expand Down @@
+33 −2		CMakeLists.txt
+4 −1		cmake/common_build_flags.cmake
+75 −22		include/wil/com.h
+88 −87		include/wil/common.h
+25 −4		include/wil/cppwinrt.h
+116 −8		include/wil/filesystem.h
+284 −44		include/wil/resource.h
+5 −5		include/wil/result.h
+653 −203		include/wil/result_macros.h
+31 −2		include/wil/result_originate.h
+2 −1		include/wil/safecast.h
+3 −11		include/wil/stl.h
+4 −0		include/wil/token_helpers.h
+71 −22		include/wil/win32_helpers.h
+45 −32		include/wil/winrt.h
+1 −1		include/wil/wistd_config.h
+1 −0		include/wil/wistd_functional.h
+17 −0		include/wil/wistd_type_traits.h
+32 −32		scripts/azure-pipelines.yml
+31 −4		scripts/init.cmd
+2 −0		scripts/runtests.cmd
+4 −3		tests/CMakeLists.txt
+111 −92		tests/ComTests.cpp
+100 −0		tests/FileSystemTests.cpp
+46 −0		tests/ResourceTests.cpp
+5 −2		tests/ResultTests.cpp
+6 −0		tests/TokenHelpersTests.cpp
+33 −1		tests/WinRTTests.cpp
+14 −1		tests/common.h
+6 −0		tests/cpplatest/CMakeLists.txt
+15 −4		tests/wiTest.cpp
+21 −0		tests/win7/CMakeLists.txt
+11 −11		tests/workarounds/wrl/wrl/implements.h