Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notify UIA when Search finds something #5478

Merged
merged 2 commits into from
Apr 29, 2020
Merged

Notify UIA when Search finds something #5478

merged 2 commits into from
Apr 29, 2020

Conversation

carlos-zamora
Copy link
Member

Summary of the Pull Request

Before this, if the Search Box was open, new selections would not notify automation clients. This was because the UiaEngine (responsible for notifying automation clients) would remain disabled. Now we're enabling it before the early exit in TermControl's FocusHandler

PR Checklist

Validation Steps Performed

Verified using NVDA.
Narrator's behavior is not impacted, for some reason.

@carlos-zamora carlos-zamora added Area-Accessibility Issues related to accessibility Product-Terminal The new Windows Terminal. labels Apr 22, 2020
zadjii-msft
zadjii-msft approved these changes Apr 23, 2020
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure sounds good

@carlos-zamora carlos-zamora added the AutoMerge Marked for automatic merge by the bot when requirements are met label Apr 28, 2020
@ghost
Copy link

ghost commented Apr 28, 2020

Hello @carlos-zamora!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@zadjii-msft zadjii-msft added the Needs-Second It's a PR that needs another sign-off label Apr 29, 2020
@ghost ghost requested review from miniksa and leonMSFT April 29, 2020 13:50
leonMSFT
leonMSFT approved these changes Apr 29, 2020
View reviewed changes
Copy link
Contributor

@leonMSFT leonMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

@carlos-zamora carlos-zamora added AutoMerge Marked for automatic merge by the bot when requirements are met and removed AutoMerge Marked for automatic merge by the bot when requirements are met labels Apr 29, 2020
@carlos-zamora carlos-zamora merged commit 6d41072 into master Apr 29, 2020
@carlos-zamora carlos-zamora deleted the dev/cazamor/a11y/search-box branch April 29, 2020 17:36
@ghost
Copy link

ghost commented May 5, 2020

🎉Windows Terminal Release Candidate v0.11.1251.0 (1.0rc1) has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonMSFT leonMSFT leonMSFT approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@DHowett-MSFT DHowett-MSFT Awaiting requested review from DHowett-MSFT

@miniksa miniksa Awaiting requested review from miniksa

Assignees
No one assigned
Labels
Area-Accessibility Issues related to accessibility AutoMerge Marked for automatic merge by the bot when requirements are met Needs-Second It's a PR that needs another sign-off Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlos-zamora @zadjii-msft @leonMSFT