Apply dark window borders to NonClientIslandWindow using ThemeHelpers #4817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DHowett-MSFT
commented
Mar 5, 2020
| @@ -485,6 +486,9 @@ void NonClientIslandWindow::_UpdateFrameMargins() const noexcept | |||
| return _OnNcHitTest({ GET_X_LPARAM(lParam), GET_Y_LPARAM(lParam) }); | |||
| case WM_PAINT: | |||
| return _OnPaint(); | |||
| case WM_ACTIVATE: | |||
| // If we do this every time we're activated, it should be close enough to correct. | |||
| TerminalTrySetDarkTheme(_window.get()); | |||
There was a problem hiding this comment.
We don't care if this fails.
There was a problem hiding this comment.
Not even enough to log it.
carlos-zamora
approved these changes
Mar 5, 2020
|
@msftbot merge this in 2 minutes |
ghost
added
the
AutoMerge
|
Hello @zadjii-msft! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
|
I made sure that this put the dll file in the x64 appx layout, but I'll be watching our prod builds to make sure. |
ghost
merged commit 
5 tasks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solution was vetted by the DWM team.
Fixes #3425.