Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for tab drag and drop #3478

Merged
merged 5 commits into from
Nov 8, 2019
Merged

Add support for tab drag and drop #3478

merged 5 commits into from
Nov 8, 2019

Conversation

clarkezone
Copy link
Contributor

@clarkezone clarkezone commented Nov 8, 2019 •
edited
Loading

Summary of the Pull Request

Add support for rearranging open tabs via drag and drop

References

PR Checklist

  • Closes Add support for tab reordering #443
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@clarkezone clarkezone changed the title Add support for tag drag and drop Add support for tab drag and drop Nov 8, 2019
@clarkezone
Copy link
Contributor Author

Unclear how to run formatting tests offline

@zadjii-msft
Copy link
Member

@clarkezone try tools\runformat.cmd from the root of the project :)

zadjii-msft
zadjii-msft reviewed Nov 8, 2019
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that my concerns rise above the nit level, and I really want to see this land. I'm not gonna block this, but I'll let two other people be the green checks.

Thanks for the (much needed) QOL improvement!

src/cascadia/TerminalApp/TerminalPage.cpp Outdated Show resolved Hide resolved
src/cascadia/TerminalApp/TerminalPage.cpp Show resolved Hide resolved
src/cascadia/TerminalApp/TerminalPage.cpp Show resolved Hide resolved
zadjii-msft
zadjii-msft approved these changes Nov 8, 2019
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for changing that! I'm fine with signing off on this now.

src/cascadia/TerminalApp/TerminalPage.h Outdated Show resolved Hide resolved
clarkezone
clarkezone commented Nov 8, 2019
View reviewed changes
Copy link
Contributor Author

@clarkezone clarkezone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good now.

@zadjii-msft zadjii-msft added Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. labels Nov 8, 2019
miniksa
miniksa approved these changes Nov 8, 2019
View reviewed changes
Copy link
Member

@miniksa miniksa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh. I somehow thought it would be more involved than that. Excellent. Thank you very much!

@miniksa miniksa merged commit bd1604a into microsoft:master Nov 8, 2019
@DHowett-MSFT
Copy link
Contributor

Moderately concerned that if a tab is carried out of a window when showTabsInTitlebar=false and alwaysShowTabs=false, the tab bar will disappear and never come back

@DHowett-MSFT
Copy link
Contributor

(we call _UpdateTabBar in TabItemsChanging, which may set visibility)

This was referenced Nov 8, 2019
Closed
Closed
@cinnamon-msft cinnamon-msft added this to the Terminal-1911 milestone Nov 12, 2019
@VikingScientist VikingScientist mentioned this pull request Nov 15, 2019
Closed
@ghost
Copy link

ghost commented Nov 26, 2019

🎉Windows Terminal Preview v0.7.3291.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Nov 26, 2019
Closed
@zadjii-msft zadjii-msft mentioned this pull request Nov 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@miniksa miniksa miniksa approved these changes

Assignees
No one assigned
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal-1911
Development

Successfully merging this pull request may close these issues.

Add support for tab reordering
5 participants
@clarkezone @zadjii-msft @DHowett-MSFT @miniksa @cinnamon-msft