Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevents DWM crashing from also crashing us #3460

Merged
merged 1 commit into from
Nov 6, 2019
Merged

Prevents DWM crashing from also crashing us #3460

merged 1 commit into from
Nov 6, 2019

Conversation

zadjii-msft
Copy link
Member

Summary of the Pull Request

It's apparently perfectly possible that DWM will just crash or close, and when it does, DwmExtendFrameIntoClientArea will return a failure. If we THROW_IF_FAILED that call, then we'll also crash when DWM does.

This converts that THROW_IF_FAILED to a LOG_IF_FAILED. When DWM comes back, we'll hit this codepath again, and all will be right again in the world.

PR Checklist

Validation Steps Performed

taskkill /f /im dwm.exe used to crash us too, now it onlt takes down DWM.

@zadjii-msft
Prevents DWM crashing from also crashing us
dcfb0c4 
  It's apparently perfectly possible that DWM will just crash or close, and when
  it does, `DwmExtendFrameIntoClientArea` will return a failure. If we
  THROW_IF_FAILED that call, then we'll also crash when DWM does.

  This converts that THROW_IF_FAILED to a LOG_IF_FAILED. When DWM comes back,
  we'll hit this codepath again, and all will be right again in the world.
@zadjii-msft zadjii-msft added Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Severity-Crash Crashes are real bad news. Product-Terminal The new Windows Terminal. labels Nov 6, 2019
DHowett-MSFT
DHowett-MSFT approved these changes Nov 6, 2019
View reviewed changes
Copy link
Contributor

@DHowett-MSFT DHowett-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100%

@DHowett-MSFT DHowett-MSFT added the Needs-Second It's a PR that needs another sign-off label Nov 6, 2019
@ghost ghost requested review from miniksa and carlos-zamora November 6, 2019 18:41
miniksa
miniksa approved these changes Nov 6, 2019
View reviewed changes
Copy link
Member

@miniksa miniksa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for maintaining the "trip upstate" wording in the comments. Good stuff.

@miniksa miniksa merged commit 3df2924 into master Nov 6, 2019
@miniksa miniksa deleted the dev/migrie/b/2735-dont-let-dwm-187-us branch November 6, 2019 18:56
@ghost
Copy link

ghost commented Nov 26, 2019

🎉Windows Terminal Preview v0.7.3291.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Nov 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miniksa miniksa miniksa approved these changes

@DHowett-MSFT DHowett-MSFT DHowett-MSFT approved these changes

@carlos-zamora carlos-zamora Awaiting requested review from carlos-zamora

Assignees
No one assigned
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Needs-Second It's a PR that needs another sign-off Product-Terminal The new Windows Terminal. Severity-Crash Crashes are real bad news.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Terminal takes a trip upstate when DWM crashes
3 participants
@zadjii-msft @DHowett-MSFT @miniksa