Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Starting Directory for WSL profile #2033

Merged
merged 1 commit into from
Jul 26, 2019

Conversation

mervynzhang
Copy link
Contributor

@mervynzhang mervynzhang commented Jul 19, 2019

Summary of the Pull Request

Set Starting Directory for WSL profile

References

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Currently, WSL Starting Directory is /mnt/c/WINDOWS/system32, it's better to be in /mnt/c/Users/UserName directory.

This only take effects if no existing profile.

Validation Steps Performed

Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me. Ideally we'd set it to the linux home path, but since we can't possibly know that when these are generated, and we can't just set it to a linux path directly, this seems like a good and righteous change to me.

@carlos-zamora carlos-zamora merged commit 83a4c22 into microsoft:master Jul 26, 2019
@ghost
Copy link

ghost commented Aug 3, 2019

🎉Windows Terminal Preview v0.3.2142.0 has been released which incorporates this pull request.:tada:

Handy links:

@Buslowicz
Copy link

I have an up-to-date version of the terminal, but still get the system32 path by default for my Ubuntu wsl. What should I do to change this behavior to match the one proposed in the above PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants