Add Vintage color scheme to defaults; fixes #1781 #1901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing done: All manual tests: - Deleted profiles.json, started Terminal. - Verified that the output "Vintage" color scheme existed. - Verified that "Vintage" diffed equal to the "Classic" scheme in the issue, apart from the name and the addition of "background" and "foreground" colors, which I made equal to the "black" and "white" ones respectively. - Verified that I could set a profile to use Vintage and that the colors changed accordingly.
DHowett-MSFT
added
the
AutoMerge
|
Hello @DHowett-MSFT! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 7 hours 57 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
metathinker
changed the title
zadjii-msft
approved these changes
Jul 10, 2019
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ghost
merged commit
mcpiroman
pushed a commit
to mcpiroman/terminal
that referenced
this pull request
Jul 23, 2019
…soft#1901) Testing done: All manual tests: - Deleted profiles.json, started Terminal. - Verified that the output "Vintage" color scheme existed. - Verified that "Vintage" diffed equal to the "Classic" scheme in the issue, apart from the name and the addition of "background" and "foreground" colors, which I made equal to the "black" and "white" ones respectively. - Verified that I could set a profile to use Vintage and that the colors changed accordingly.
|
🎉 Handy links: |
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the "Classic" color scheme to the ones in the default
profiles.jsonsettings file, with the colors suggested by @ocalvo in issue #1781. I named it "Vintage" per @DHowett-MSFT's suggestion.PR Checklist
Validation Steps Performed
All manual tests. I didn't feel it was necessary to add any automated tests because the only ones that would make sense would be ones to check that other default color schemes aren't regressed, and we don't have any tests for default settings today (presumably because they change too often!).
profiles.json, started Terminal.profiles.jsonfile.