Bugfix: only round to the nearest cell for selection #18486
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Fixes a bug where VT mouse mode would round to the nearest cell when clicking the mouse button.
The fix is to round to the nearest cell only when we're selecting text. The other scenarios affected are:
Really the most notable ones were the first two. So now, we use the position of the cell we clicked on. We only round for selection.
References and Relevant Issues
Follow-up to #18106
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
Opened Midnight Commander in Ubuntu and clicked between the two panes.