Fix 'closeWindow' ignoring confirmation #18434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Issue-Bug
carlos-zamora
added a commit
that referenced
this pull request
Jan 20, 2025
DHowett
approved these changes
Jan 21, 2025
DHowett
pushed a commit
that referenced
this pull request
Jan 28, 2025
Reroutes the `closeWindow` action to use the `CloseWindow()` method like the window's X button does. This includes logic to display the confirmation dialog. Also removes `CloseRequested` as it was only used by this action handler. We already have `CloseWindowRequested` so we're just using that instead. ## Validation Steps Performed ✅ `closeWindow` action while multiple tabs opened brings up the confirmation dialog Closes #17613 (cherry picked from commit fb7b0e1) Service-Card-Id: PVTI_lADOAF3p4s4AmhmQzgWkUeU Service-Version: 1.22
DHowett
pushed a commit
that referenced
this pull request
Jan 28, 2025
Reroutes the `closeWindow` action to use the `CloseWindow()` method like the window's X button does. This includes logic to display the confirmation dialog. Also removes `CloseRequested` as it was only used by this action handler. We already have `CloseWindowRequested` so we're just using that instead. ## Validation Steps Performed ✅ `closeWindow` action while multiple tabs opened brings up the confirmation dialog Closes #17613 (cherry picked from commit fb7b0e1) Service-Card-Id: PVTI_lADOAF3p4s4AmhmszgWkUeM Service-Version: 1.21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Reroutes the
closeWindowaction to use theCloseWindow()method like the window's X button does. This includes logic to display the confirmation dialog.Also removes
CloseRequestedas it was only used by this action handler. We already haveCloseWindowRequestedso we're just using that instead.Validation Steps Performed
✅
closeWindowaction while multiple tabs opened brings up the confirmation dialogPR Checklist
Closes #17613