Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The start of some User docs #1577

Merged
merged 45 commits into from
Jul 8, 2019
Merged

The start of some User docs #1577

merged 45 commits into from
Jul 8, 2019

Conversation

alecthegeek
Copy link
Contributor

Summary of the Pull Request

Some new user documentation to help users get started with Windows Terminal.

References

References: #1576

  • Closes #xxx
  • [ X] CLA signed. If not, go over here and sign the CLA
  • [ N/A] Tests added/passed
  • [ X] Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #

Detailed Description of the Pull Request / Additional comments

New file with some simple end user information added. This will need to grow.

Validation Steps Performed

None at this time

@alecthegeek alecthegeek changed the title The starr of some User docs The start of some User docs Jun 25, 2019
Copy link

@JushBJJ JushBJJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include the path file of profiles.json in case users have issues opening .json file extension.
C:\Users\Your_Username\AppData\Local\Packages\WindowsTerminalDev_<some_characters>\RoamingState\profiles.json

@ghost ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jun 25, 2019
@JushBJJ
Copy link

JushBJJ commented Jun 25, 2019

Though, when gui settings for the terminal comes in, this needs to be changed in the future.

Copy link

@JushBJJ JushBJJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a tip on how to put gifs or background images in the terminal.
Refer to #1528

doc/user-docs/index.md Outdated Show resolved Hide resolved
doc/user-docs/index.md Outdated Show resolved Hide resolved
doc/user-docs/index.md Outdated Show resolved Hide resolved
doc/user-docs/index.md Outdated Show resolved Hide resolved
Co-Authored-By: Michael Niksa <[email protected]>
@ghost ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jun 25, 2019
@alecthegeek
Copy link
Contributor Author

Include the path file of profiles.json in case users have issues opening .json file extension.
C:\Users\Your_Username\AppData\Local\Packages\WindowsTerminalDev_<some_characters>\RoamingState\profiles.json

Done

Copy link

@JushBJJ JushBJJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include the minimum requirements at ### From the Microsoft Store section or similar.

@ghost ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jun 25, 2019
@ghost ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jun 26, 2019
@alecthegeek
Copy link
Contributor Author

Add a tip on how to put gifs or background images in the terminal.
Refer to #1528

Done

@alecthegeek
Copy link
Contributor Author

Include the minimum requirements at ### From the Microsoft Store section or similar.

Welll I figure that might change, so I've put a note saying "review minimum requirements"

alecthegeek and others added 12 commits July 1, 2019 18:33
Co-Authored-By: Kayla Cinnamon <[email protected]>
Co-Authored-By: Kayla Cinnamon <[email protected]>
Co-Authored-By: Kayla Cinnamon <[email protected]>
Co-Authored-By: Kayla Cinnamon <[email protected]>
Co-Authored-By: Kayla Cinnamon <[email protected]>
Co-Authored-By: Kayla Cinnamon <[email protected]>
Co-Authored-By: Kayla Cinnamon <[email protected]>
Co-Authored-By: Kayla Cinnamon <[email protected]>
1. Merged in comments from PR
2. Made colour color :-(
3. Other tidy ups
@alecthegeek
Copy link
Contributor Author

I've pretty mush exhausted my current knowledge of Windows Terminal.

Can anyone point me to other sources of information?

@cinnamon-msft
Copy link
Contributor

This looks great! For the TODOs, I would recommend either removing them or adding the GitHub issue number they're associated with.

1. Some notes abouet cut and paste -- needs more work
2. Get rid of TODO -- replace with links to issues
3. Add some extra notes about URI for background images
@alecthegeek
Copy link
Contributor Author

Well I think I've addressed all the comments, but GitHub says no. Can't find the outstanding request

@zadjii-msft zadjii-msft requested a review from bitcrazed July 2, 2019 13:56
@zadjii-msft zadjii-msft added the Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs label Jul 2, 2019
@ghost ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jul 2, 2019
@JushBJJ
Copy link

JushBJJ commented Jul 2, 2019

Sorry if I'm a bit late on this. But should we put in a FAQ file or section too?

@bitcrazed bitcrazed mentioned this pull request Jul 2, 2019
@cinnamon-msft
Copy link
Contributor

Sorry if I'm a bit late on this. But should we put in a FAQ file or section too?

I'm okay with adding an FAQ, but I'd prefer if we did it in a separate PR 😊

@cinnamon-msft cinnamon-msft self-requested a review July 8, 2019 18:16
@cinnamon-msft cinnamon-msft merged commit c9d8e3e into microsoft:master Jul 8, 2019
mcpiroman pushed a commit to mcpiroman/terminal that referenced this pull request Jul 23, 2019
* Start User docs

* Fix typos

* Addded some more TODO

* Update doc/user-docs/index.md

Co-Authored-By: Michael Niksa <[email protected]>

* Update doc/user-docs/index.md

Co-Authored-By: Michael Niksa <[email protected]>

* Update doc/user-docs/index.md

Co-Authored-By: Michael Niksa <[email protected]>

* Update doc/user-docs/index.md

Co-Authored-By: Michael Niksa <[email protected]>

* Updated from suggestions in the PR

* Improve path to profiles.json

* Added some details about Json settings

* Example Json settings, and a #TODO

* Update doc/user-docs/UsingJsonSettings.md

Co-Authored-By: Kayla Cinnamon <[email protected]>

* Update doc/user-docs/UsingJsonSettings.md

Co-Authored-By: Kayla Cinnamon <[email protected]>

* Update doc/user-docs/UsingJsonSettings.md

Co-Authored-By: Kayla Cinnamon <[email protected]>

* Update doc/user-docs/index.md

Co-Authored-By: Kayla Cinnamon <[email protected]>

* Update doc/user-docs/index.md

Co-Authored-By: Kayla Cinnamon <[email protected]>

* Update doc/user-docs/index.md

Co-Authored-By: Kayla Cinnamon <[email protected]>

* Update doc/user-docs/index.md

Co-Authored-By: Kayla Cinnamon <[email protected]>

* Update doc/user-docs/index.md

Co-Authored-By: Kayla Cinnamon <[email protected]>

* Update doc/user-docs/UsingJsonSettings.md

Co-Authored-By: Kayla Cinnamon <[email protected]>

* Update doc/user-docs/UsingJsonSettings.md

Co-Authored-By: Kayla Cinnamon <[email protected]>

* Update doc/user-docs/UsingJsonSettings.md

Co-Authored-By: Kayla Cinnamon <[email protected]>

* Update doc/user-docs/UsingJsonSettings.md

Co-Authored-By: Kayla Cinnamon <[email protected]>

* Update doc/user-docs/UsingJsonSettings.md

Co-Authored-By: Kayla Cinnamon <[email protected]>

* Update doc/user-docs/UsingJsonSettings.md

Co-Authored-By: Kayla Cinnamon <[email protected]>

* Update doc/user-docs/UsingJsonSettings.md

Co-Authored-By: Kayla Cinnamon <[email protected]>

* Update doc/user-docs/UsingJsonSettings.md

Co-Authored-By: Kayla Cinnamon <[email protected]>

* Update doc/user-docs/UsingJsonSettings.md

Co-Authored-By: Kayla Cinnamon <[email protected]>

* Update doc/user-docs/UsingJsonSettings.md

Co-Authored-By: Kayla Cinnamon <[email protected]>

* Update doc/user-docs/UsingJsonSettings.md

Co-Authored-By: Kayla Cinnamon <[email protected]>

* Update doc/user-docs/UsingJsonSettings.md

Co-Authored-By: Kayla Cinnamon <[email protected]>

* Update doc/user-docs/index.md

Co-Authored-By: Kayla Cinnamon <[email protected]>

* Update doc/user-docs/index.md

Co-Authored-By: Kayla Cinnamon <[email protected]>

* Update doc/user-docs/index.md

Co-Authored-By: Kayla Cinnamon <[email protected]>

* Update doc/user-docs/index.md

Co-Authored-By: Kayla Cinnamon <[email protected]>

* Update doc/user-docs/index.md

Co-Authored-By: Kayla Cinnamon <[email protected]>

* Update doc/user-docs/index.md

Co-Authored-By: Kayla Cinnamon <[email protected]>

* Update doc/user-docs/index.md

Co-Authored-By: Kayla Cinnamon <[email protected]>

* Update doc/user-docs/index.md

Co-Authored-By: Kayla Cinnamon <[email protected]>

* After review and make colour US.

1. Merged in comments from PR
2. Made colour color :-(
3. Other tidy ups

* Added more detais about background images

* Remove some TODO comments and minot tidy up

* Get rid of TODO

1. Some notes abouet cut and paste -- needs more work
2. Get rid of TODO -- replace with links to issues
3. Add some extra notes about URI for background images
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants