-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow wsl$ in file URIs; generally allow all URI schemes #14993
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm cool with this.
@msftbot merge this in 10 minutes EDIT: or ignore me, that works too, I guess |
This is great, so many possibilities ! I'm just a random guy wondering if the first terminal/src/cascadia/TerminalApp/TerminalPage.cpp Lines 2463 to 2466 in be62c22
the function would return true anyways right? |
@Araxeus necessary, no, but IMO it's better to maintain. You're still explicitly allowing HTTP/S but that fallback may change in the future. Will future maintainers remember to explicitly handle HTTP/S again? A lot would be broken if not. Also allows more understandable comments, IMO, and is neither a hot path nor all that slow anyway so a refactor doesn't seem worth the potential maintenance issues. |
Does two things related to URLs emitted via OSC8. * Allows `wsl$` and `wsl.localhost` as the hostname in `file://` URIs * Generally allows _all_ URIs that parse as a URI. The relevant security comments: #7526 (comment) > this doesn't let a would-be attacker specify command-line arguments (ala "cmd.exe /s /c do_a_bad_thing") (using somebody else's reputation to cause mayhem) > > `ShellExecute` de-elevates because it bounces a launch request off the shell > > "Works predictably for 15% of applications" (h/t to PhMajerus' AXSH, and other on-Windows requestors) is better in so many ways than "Works for 0% of applications", in my estimation. Incremental progress 😄 while we work on features that'll make it even more broadly applicable. Closes #10188 Closes #7562 (cherry picked from commit 65640f6) Service-Card-Id: 88719284 Service-Version: 1.17
Does two things related to URLs emitted via OSC8.
wsl$
andwsl.localhost
as the hostname infile://
URIsThe relevant security comments: #7526 (comment)
Closes #10188
Closes #7562
discuss