Clearly differentiate running elevated vs. drag/drop breaking #14946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/drop Credit where credit is due - @jboelter did literally all the hard work. I just separated this out to two elements: * Are we running elevated? * Can we drag drop? As we learned in #7754, the builtin administrator _can_ drag drop. But critically, they are also running as admin! The way we had this logic before, we're treat them as unelevated, because we had been overloading the meaning here. This splits these into two separate functions. Comes with the added benefit of re-adding the elevation shield to the Terminal window for users with UAC disabled (which was missing before) (and can _still_ be disabled). Closes #13928 Tested on a Win10 VM with `EnableLua=0`
microsoft-github-policy-service
bot
added
Issue-Bug
This comment has been minimized.
This comment has been minimized.
…then it's not fine. Fine, fine.
DHowett
requested changes
Mar 3, 2023
microsoft-github-policy-service
bot
added
the
Needs-Author-Feedback
microsoft-github-policy-service
bot
removed
the
Needs-Author-Feedback
DHowett
reviewed
Mar 8, 2023
|
Thanks God! Finally someone spotted this! But my tests on Windows 11 shows that drag&drop file is still not working (with EnableLUA=0) |
DHowett
approved these changes
Mar 14, 2023
microsoft-github-policy-service
bot
requested review from
PankajBhojwani,
carlos-zamora,
DHowett and
lhecker
DHowett
approved these changes
Mar 17, 2023
microsoft-github-policy-service
bot
removed
the
Needs-Second
carlos-zamora
approved these changes
Mar 17, 2023
| } | ||
| }(); | ||
|
|
||
| return !isDragDropBroken; |
There was a problem hiding this comment.
I mean, you did the hard part of writing the logic. Why not remove the double negative by...
isDragDropBroken-->canDragDrop- L681
false-->true - L693
true-->false - L697
!isDragDropBroken-->canDragDrop
(pipe the ! into the returned results, basically)
Comment on lines
+139
to
+140
| _isElevated = ::Microsoft::Console::Utils::IsRunningElevated(); | ||
| _canDragDrop = ::Microsoft::Console::Utils::CanUwpDragDrop(); |
There was a problem hiding this comment.
I guess this kinda isn't relevant to this PR but why do these two members exist? We're using magic statics in Utils, so what's the point in caching these values?
DHowett
changed the title
|
(I chose to merge without seeing your comments -- @zadjii-msft, mind tracking them?) |
DHowett
pushed a commit
that referenced
this pull request
May 15, 2023
Credit where credit is due - @jboelter did literally all the hard work. I just separated this out to two elements: * Are we running elevated? * Can we drag drop? As we learned in #7754, the builtin administrator _can_ drag drop. But critically, they are also running as admin! The way we had this logic before, we're treat them as unelevated, because we had been overloading the meaning here. This splits these into two separate functions. Comes with the added benefit of re-adding the elevation shield to the Terminal window for users with UAC disabled (which was missing before) (and can _still_ be disabled). Closes #13928 Tested on a Win10 VM with `EnableLua=0` (cherry picked from commit c5c15e8) Service-Card-Id: 88484047 Service-Version: 1.17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credit where credit is due - @jboelter did literally all the hard work.
I just separated this out to two elements:
As we learned in #7754, the builtin administrator can drag drop. But critically, they are also running as admin! The way we had this logic before, we're treat them as unelevated, because we had been overloading the meaning here.
This splits these into two separate functions. Comes with the added benefit of re-adding the elevation shield to the Terminal window for users with UAC disabled (which was missing before) (and can still be disabled).
Closes #13928
Tested on a Win10 VM with
EnableLua=0