-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for updates automatically (but don't install) #13437
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
either we hook the button up, or we just hide it. IDC which.
<Run x:Uid="AboutDialog_VersionLabel" /> | ||
<Run Text="{x:Bind PendingUpdateVersion, Mode=OneWay}" /> | ||
</TextBlock> | ||
<Button Content="Install now" Margin="0"></Button> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.... Do we know how to force the store to install an update for us? StoreContext.RequestDownloadAndInstallStorePackageUpdatesAsync
presumably? Can we even locally test if that works?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you mean without user confirmation (silently) this could help according to docs: https://docs.microsoft.com/en-us/windows/uwp/packaging/self-install-package-updates#download-and-install-package-updates-silently
But why didn't you only opening the updates page in store? And what happened if stire isn't available/removed?
I must remove the old bits from TP
Meh. I think we can do that in a follow-up.
I got chu fam
Meh. I think we can do that in a follow-up. I also think we should disable the "Install Update" button, and fast-follow with the follow up that does this. (I'm bumping this, so that we can put it in the next selfhost, so that we can test if it works with the next-next selfhost. ) |
Potential follow-upsmoved from OP
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also helped here so I dunno if I count
@msftbot merge this in like 2 days rip little buddy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I like it again. Thanks for carrying this over the finish line @zadjii-msft
This PR adds support to the About Dialog for checking the store to see if there's a new version of the Terminal package available. We'll only do this once per day, per terminal window.
In dev mode, we'll always fake it and say there's an update to
x.y.z
available.This also involved pulling all of the About dialog code out into its own class. All that is goodness.
We don't currently provide a button for installing the update. We just check. Incremental progress is better than none.