Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for updates automatically (but don't install) #13437

Merged
merged 12 commits into from
Apr 6, 2023

Conversation

DHowett
Copy link
Member

@DHowett DHowett commented Jul 5, 2022

This PR adds support to the About Dialog for checking the store to see if there's a new version of the Terminal package available. We'll only do this once per day, per terminal window.

In dev mode, we'll always fake it and say there's an update to x.y.z available.

This also involved pulling all of the About dialog code out into its own class. All that is goodness.

We don't currently provide a button for installing the update. We just check. Incremental progress is better than none.

@DHowett
Copy link
Member Author

DHowett commented Jul 5, 2022

image

image

Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

either we hook the button up, or we just hide it. IDC which.

src/cascadia/TerminalApp/TerminalPage.cpp Outdated Show resolved Hide resolved
src/cascadia/TerminalApp/TerminalPage.cpp Outdated Show resolved Hide resolved
<Run x:Uid="AboutDialog_VersionLabel" />
<Run Text="{x:Bind PendingUpdateVersion, Mode=OneWay}" />
</TextBlock>
<Button Content="Install now" Margin="0"></Button>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.... Do we know how to force the store to install an update for us? StoreContext.RequestDownloadAndInstallStorePackageUpdatesAsync presumably? Can we even locally test if that works?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you mean without user confirmation (silently) this could help according to docs: https://docs.microsoft.com/en-us/windows/uwp/packaging/self-install-package-updates#download-and-install-package-updates-silently

But why didn't you only opening the updates page in store? And what happened if stire isn't available/removed?

@DHowett DHowett changed the title WIP: Check for updates when the about dialog is opened WIP: Check for updates automatically Jan 25, 2023
@zadjii-msft
Copy link
Member

TODO before review

  • Display a badge on the new tab dropdown/menu item for About

Meh. I think we can do that in a follow-up.

  • Resolve XAML styling issue in split-out AboutDialog class (or file upstream)

I got chu fam

  • Discuss with team - display an info bar if the update is more than 3 days old?

Meh. I think we can do that in a follow-up.

I also think we should disable the "Install Update" button, and fast-follow with the follow up that does this.

(I'm bumping this, so that we can put it in the next selfhost, so that we can test if it works with the next-next selfhost. )

@zadjii-msft zadjii-msft marked this pull request as ready for review April 5, 2023 16:29
@zadjii-msft
Copy link
Member

Potential follow-ups

moved from OP

Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also helped here so I dunno if I count

@zadjii-msft zadjii-msft changed the title WIP: Check for updates automatically Check for updates automatically (but don't install) Apr 6, 2023
@zadjii-msft
Copy link
Member

@msftbot merge this in like 2 days

rip little buddy

Copy link
Member Author

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I like it again. Thanks for carrying this over the finish line @zadjii-msft

@DHowett DHowett merged commit ea44375 into main Apr 6, 2023
@DHowett DHowett deleted the dev/duhowett/check-for-updates branch April 6, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants