Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the cursor blink VT sequence being ignored #10589

Merged
2 commits merged into from
Jul 9, 2021
Merged

Fix the cursor blink VT sequence being ignored #10589

2 commits merged into from
Jul 9, 2021

Conversation

PankajBhojwani
Copy link
Contributor

@PankajBhojwani PankajBhojwani commented Jul 8, 2021 •
edited by DHowett
Loading

Ensure that the cursor blink VT sequence gets flushed to terminal when conhost is attached to a pty

Closes #10543

@ghost ghost added Area-VT Virtual Terminal sequence support Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Conpty For console issues specifically related to conpty labels Jul 8, 2021
miniksa
miniksa reviewed Jul 8, 2021
View reviewed changes
src/host/outputStream.cpp

bool isPty;
DoSrvIsConsolePty(isPty);
// If we are connected to a pty, return that we could not handle this
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confusing. We did handle it by turning on our own blinking... didn't we with DoSrvPrivateAllowCursorBlinking above?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Returning false in an event handler for the VT Parser's OutputStateMachineEngine has been overloaded to mean, "Pass this through to the connected terminal."

This is not the first, and will likely not be the last, case in which we do this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we are saying that we need to process it AND the connected terminal needs to process it too... right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So technically we don't need to process it ourselves, only the connected terminal needs to. I've done it this way just so there's consistency between the two, just in case.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just leave that as a comment then to inform a future reader, please, and I'm good then.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, added!

@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Jul 9, 2021
@ghost
Copy link

ghost commented Jul 9, 2021

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 6409ab9 into main Jul 9, 2021
@ghost ghost deleted the dev/pabhoj/cursor_blink branch July 9, 2021 18:45
@DHowett DHowett added the zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes. label Jul 12, 2021
DHowett pushed a commit that referenced this pull request Jul 12, 2021
@PankajBhojwani @DHowett
Fix the cursor blink VT sequence being ignored (#10589)
91d599b 
Ensure that the cursor blink VT sequence gets flushed to terminal when conhost is attached to a pty

Closes #10543

(cherry picked from commit 6409ab9)
@ghost
Copy link

ghost commented Jul 14, 2021

🎉Windows Terminal v1.9.1942.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Jul 14, 2021
Closed
@ghost
Copy link

ghost commented Jul 14, 2021

🎉Windows Terminal Preview v1.10.1933.0 has been released which incorporates this pull request.:tada:

Handy links:

@polluks
Copy link

polluks commented Aug 17, 2021

Maybe there should be a warning like https://unix.stackexchange.com/a/3769/277889.

@DHowett DHowett removed the zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes. label Aug 25, 2021
@zadjii-msft zadjii-msft mentioned this pull request Sep 7, 2021
Open
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miniksa miniksa miniksa left review comments

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@DHowett DHowett DHowett approved these changes

Assignees
No one assigned
Labels
Area-VT Virtual Terminal sequence support AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Conpty For console issues specifically related to conpty
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ConPTY does not pass cursor blinking VT sequence (DECSET/DECRST 12)
5 participants
@PankajBhojwani @polluks @DHowett @miniksa @zadjii-msft