Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panes should be resizable with the keyboard. #991

Closed
zadjii-msft opened this issue May 24, 2019 · 1 comment · Fixed by #1207
Closed

Panes should be resizable with the keyboard. #991

zadjii-msft opened this issue May 24, 2019 · 1 comment · Fixed by #1207
Assignees
@zadjii-msft
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v0.3

Comments

@zadjii-msft
Copy link
Member

Press a keybinding to adjust the width/height of a pair of panes.

This comes with extra work - we have to have each parent pane track the relative size of each child, and then when the window is resized, recursively resize each control to match the absolute size to the previous proportions. Currently, we're just using two row/cols of equal width.

Start with some simple amount, like 5% at a time. Adjusting by a single char at a time would only be possible if both panes were the same font size, which isn't guaranteed.
@zadjii-msft zadjii-msft added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label May 24, 2019
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 24, 2019
@zadjii-msft zadjii-msft added Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels May 24, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label May 24, 2019
@zadjii-msft zadjii-msft added Needs-Tag-Fix Doesn't match tag requirements and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels May 24, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label May 24, 2019
@zadjii-msft zadjii-msft added this to the Terminal v1.0 milestone May 24, 2019
This was referenced May 24, 2019
Open
Merged
Open
@DHowett-MSFT DHowett-MSFT removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels May 24, 2019
@zadjii-msft zadjii-msft self-assigned this Jun 10, 2019
@zadjii-msft zadjii-msft mentioned this issue Jun 11, 2019
Merged
4 tasks
zadjii-msft added a commit that referenced this issue Jun 19, 2019
@zadjii-msft
Add comments to prepare for PR
a29efa3 
  This is blocked on #991 getting in first.
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. labels Jul 10, 2019
@ghost
Copy link

ghost commented Aug 3, 2019

🎉This issue was addressed in #1207, which has now been successfully released as Windows Terminal Preview v0.3.2142.0.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zadjii-msft zadjii-msft

Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v0.3
Development

Successfully merging a pull request may close this issue.

Enable resizing the panes with the keyboard. microsoft/terminal
2 participants
@DHowett-MSFT @zadjii-msft