Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming the window should display confirmation #9804

Closed
cinnamon-msft opened this issue Apr 13, 2021 · 2 comments · Fixed by #9808
Closed

Renaming the window should display confirmation #9804

cinnamon-msft opened this issue Apr 13, 2021 · 2 comments · Fixed by #9808
Assignees
@zadjii-msft
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.9

Comments

@cinnamon-msft
Copy link
Contributor

cinnamon-msft commented Apr 13, 2021 •
edited
Loading

Windows Terminal version (or Windows build number)

1.8.1022.0

Other Software

No response

Steps to reproduce

Rename the window using the renameWindow keybinding:

{ "command": { "action": "renameWindow", "name": "Foo" }, "keys": "ctrl+u" },

Expected Behavior

Some kind of confirmation that my window has been renamed.

Actual Behavior

Nothing appears on the screen.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 13, 2021
@cinnamon-msft cinnamon-msft added Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. labels Apr 14, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Apr 14, 2021
@zadjii-msft zadjii-msft self-assigned this Apr 14, 2021
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Apr 14, 2021
@zadjii-msft zadjii-msft added this to the Terminal v1.9 milestone Apr 14, 2021
@zadjii-msft zadjii-msft mentioned this issue Apr 14, 2021
Merged
@ghost ghost added the In-PR This issue has a related PR label Apr 14, 2021
@ghost ghost closed this as completed in #9808 Apr 22, 2021
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Apr 22, 2021
ghost pushed a commit that referenced this issue Apr 22, 2021
@zadjii-msft
Add a success dialog to window renaming (#9808)
aa54de1 
I added a `RenameSucceededText` property to the `TerminalPage` which returns the
formatted message `Successfully renamed window to "{WindowNameForDisplay()}"`

This _doesn't_ pop the dialog when you `wt -w foo` for the first time. Only
_subsequent_ renames.

## References
* Added in #9662
* Closes #9804
DHowett pushed a commit that referenced this issue May 14, 2021
@zadjii-msft @DHowett
Add a success dialog to window renaming (#9808)
ed3feef 
I added a `RenameSucceededText` property to the `TerminalPage` which returns the
formatted message `Successfully renamed window to "{WindowNameForDisplay()}"`

This _doesn't_ pop the dialog when you `wt -w foo` for the first time. Only
_subsequent_ renames.

## References
* Added in #9662
* Closes #9804

(cherry picked from commit aa54de1)
@ghost
Copy link

ghost commented May 25, 2021

🎉This issue was addressed in #9808, which has now been successfully released as Windows Terminal v1.8.1444.0.:tada:

Handy links:

@ghost
Copy link

ghost commented May 25, 2021

🎉This issue was addressed in #9808, which has now been successfully released as Windows Terminal Preview v1.9.1445.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zadjii-msft zadjii-msft

Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.9
Development

Successfully merging a pull request may close this issue.

Add a success dialog to window renaming microsoft/terminal
2 participants
@zadjii-msft @cinnamon-msft