Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BASH] Window renamer doesn't accept ENTER/ESC for OK/CANCEL #9720

Closed
DHowett opened this issue Apr 6, 2021 · 0 comments · Fixed by #9730
Closed

[BASH] Window renamer doesn't accept ENTER/ESC for OK/CANCEL #9720

DHowett opened this issue Apr 6, 2021 · 0 comments · Fixed by #9730
Assignees
@zadjii-msft
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.8

Comments

@DHowett
Copy link
Member

DHowett commented Apr 6, 2021

originated in 4/2 bug bash
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 6, 2021
@zadjii-msft zadjii-msft added Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Priority-3 A description (P3) labels Apr 6, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Apr 6, 2021
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Apr 6, 2021
@zadjii-msft zadjii-msft self-assigned this Apr 6, 2021
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Apr 6, 2021
@zadjii-msft zadjii-msft mentioned this issue Apr 6, 2021
Merged
2 tasks
@ghost ghost added the In-PR This issue has a related PR label Apr 6, 2021
@ghost ghost closed this as completed in #9730 Apr 6, 2021
ghost pushed a commit that referenced this issue Apr 6, 2021
@zadjii-msft
Manually handle Enter and Escape in the Window Renamer (#9730)
6ca35b4 
## Summary of the Pull Request

In exactly the same fashion as the tab renamer, handle <kbd>Enter</kbd> for committing the rename, and <kbd>Escape</kbd> for dismissing the rename.

## References
* Added in #9662

## PR Checklist
* [x] Closes #9720
* [x] I work here
* [n/a] Tests added/passed
* [n/a] Requires documentation to be updated

## Validation Steps Performed
Played with it - this feels good.
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Apr 6, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zadjii-msft zadjii-msft

Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.8
Development

Successfully merging a pull request may close this issue.

Manually handle Enter and Escape in the Window Renamer microsoft/terminal
2 participants
@DHowett @zadjii-msft