Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Appearance settings in a pane aren't updating on reload #9280

Closed
cinnamon-msft opened this issue Feb 25, 2021 · 2 comments · Fixed by #9289
Closed

Appearance settings in a pane aren't updating on reload #9280

cinnamon-msft opened this issue Feb 25, 2021 · 2 comments · Fixed by #9289
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Blocking We won't ship a release like this! No-siree.
Milestone
Terminal v1.7

Comments

@cinnamon-msft
Copy link
Contributor

cinnamon-msft commented Feb 25, 2021 •
edited
Loading

I had a background image in a profile and then tried to update it in the settings UI while the profile was open in a pane, and the image didn't update. Same thing happened when I tried to update my color scheme while the profile was open in a pane. (I had two panes open at the time.)

Looks like this also happens when you try to enable focusFollowMouse using the settings UI. The setting is just ignored.

Environment

Windows build number: 10.0.21318.0
Windows Terminal version (if applicable): 1.7.543.0

Any other software?

Steps to reproduce

Open two panes and change the background image or color scheme in the settings UI.

Expected behavior

The pane updates its appearance to the new settings.

Actual behavior

The newly saved settings are being ignored and the pane looks the same.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Feb 25, 2021
@carlos-zamora
Copy link
Member

carlos-zamora commented Feb 25, 2021 •
edited
Loading

Repros on v1.6.10272.0 as well. Note, if you update the settings.json directly, this bug does not occur.
Does not repro on v1.5.3242.0 (using settings.json).

@DHowett DHowett added Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. labels Feb 25, 2021
@DHowett
Copy link
Member

DHowett commented Feb 25, 2021 •
edited
Loading

In 1.7, I could get it to reliably reproduce even with the JSON file.

In 1.6, I could not.

@PankajBhojwani - We're seeing an issue where settings are only applied to the first pane. I tried the following:

  1. Launch
  2. Split
  3. My background is #220033
    • image
  4. Update background to #225033
    • image
  5. Split
    • image
  6. Update background to #228033
    • image

Since you've been working in TerminalSettings propagation and pane stuff, would you mind taking a look?
This also, weirdly, impacts focus-follows-mouse. I guess we made it a TerminalSettings setting instead of leaving it in the app layer (😬)

@DHowett DHowett added the Area-Settings Issues related to settings and customizability, for console or terminal label Feb 25, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Feb 25, 2021
@DHowett DHowett added this to the Terminal v1.7 milestone Feb 25, 2021
@DHowett DHowett changed the title Appearance settings in a pane aren't updating on save in settings UI Appearance settings in a pane aren't updating on reload Feb 25, 2021
@carlos-zamora carlos-zamora mentioned this issue Feb 25, 2021
Merged
6 tasks
@PankajBhojwani PankajBhojwani mentioned this issue Feb 25, 2021
Closed
@ghost ghost added the In-PR This issue has a related PR label Feb 25, 2021
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Feb 25, 2021
DHowett pushed a commit that referenced this issue Feb 25, 2021
@PankajBhojwani
Fix settings not updating on reload (#9289)
a930aa3 
In #8602, we started passing a child of the `TerminalSettings` to the
control upon tab initialization, but forgot to do the same when new
controls get created on a pane split. 

## Validation Steps Performed
Settings reload with multiple panes works

Closes #9280
DHowett pushed a commit that referenced this issue Feb 25, 2021
@PankajBhojwani @DHowett
Fix settings not updating on reload (#9289)
e103ca5 
In #8602, we started passing a child of the `TerminalSettings` to the
control upon tab initialization, but forgot to do the same when new
controls get created on a pane split.

## Validation Steps Performed
Settings reload with multiple panes works

Closes #9280

(cherry picked from commit a930aa3)
@cloverdoser cloverdoser mentioned this issue Apr 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Blocking We won't ship a release like this! No-siree.
Projects
None yet
Milestone
Terminal v1.7
Development

Successfully merging a pull request may close this issue.

Fix settings not updating on reload microsoft/terminal
3 participants
@DHowett @carlos-zamora @cinnamon-msft