Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command Palette should support page up/down to move faster thru the options #7729

Closed
azchohfi opened this issue Sep 24, 2020 · 6 comments · Fixed by #7835
Closed

Command Palette should support page up/down to move faster thru the options #7729

azchohfi opened this issue Sep 24, 2020 · 6 comments · Fixed by #7835
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.5

Comments

@azchohfi
Copy link

Description of the new feature/enhancement

After pressing Ctrl+Shift+P, the only way to navigate thru the options is to use the key up/down. If I press Page Up or Page Down, it should move faster thru the options. Right now, I have to press the down key many times, or leave it pressed, which is far from an optimal experience.

Proposed technical implementation details (optional)

I don't believe we need this to be customizable, so a fixed "page down/up" should just go to the end of the visible list, showing more options available, similar to how XAML's ListView already handles this scenario.
@azchohfi azchohfi added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Sep 24, 2020
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Sep 24, 2020
@DHowett
Copy link
Member

DHowett commented Sep 24, 2020

I mean, sure, but command palette is meant to be searched.

@azchohfi
Copy link
Author

azchohfi commented Sep 24, 2020 •
edited
Loading

Yes... but if you want the last option on the list after typing only a few characters, it should support moving thru the options slightly faster. Other keys, such as "End" and "Home", should also work as expected. Its frustrating that this is a list, yet doesn't behave like one.

Example:
image
I want to reset the font size (which is the last option on the list), and I don't want to remember shortcuts, or I just forgot one of them. I want to press End or PageDown and not KeyDown 6 times.

@zadjii-msft
Copy link
Member

Yeah I totally intended to do this and just forgot about it. My bad!

@DHowett DHowett added Area-UserInterface Issues pertaining to the user interface of the Console or Terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Sep 25, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Sep 25, 2020
@DHowett DHowett added this to the Terminal v1.5 milestone Sep 25, 2020
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Sep 25, 2020
@DHowett
Copy link
Member

DHowett commented Sep 25, 2020

Triaged, tagged "easy starter", marked for 1.5.

@ghost ghost mentioned this issue Sep 27, 2020
Closed
6 tasks
@ghost ghost added In-PR This issue has a related PR and removed In-PR This issue has a related PR labels Sep 27, 2020
@ghost ghost mentioned this issue Oct 4, 2020
Closed
6 tasks
@ghost ghost added In-PR This issue has a related PR and removed In-PR This issue has a related PR labels Oct 4, 2020
@ghost ghost mentioned this issue Oct 6, 2020
Merged
@ghost ghost added the In-PR This issue has a related PR label Oct 6, 2020
@ghost ghost closed this as completed in #7835 Oct 22, 2020
ghost pushed a commit that referenced this issue Oct 22, 2020
@kaihugo
Enable PgUp/PgDown and Home/End in the command palette (#7835)
293ad27 
Closes #7729
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Oct 22, 2020
DHowett pushed a commit that referenced this issue Oct 27, 2020
@kaihugo @DHowett
Enable PgUp/PgDown and Home/End in the command palette (#7835)
bb5549a 
Closes #7729

(cherry picked from commit 293ad27)
@ghost
Copy link

ghost commented Nov 11, 2020

🎉This issue was addressed in #7835, which has now been successfully released as Windows Terminal v1.4.3141.0.:tada:

Handy links:

@ghost
Copy link

ghost commented Nov 11, 2020

🎉This issue was addressed in #7835, which has now been successfully released as Windows Terminal Preview v1.5.3142.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.5
3 participants
@DHowett @azchohfi @zadjii-msft