Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TerminalCore/TerminalControl dispatch five billion cursor update coroutines when printing long file #5288

Closed
DHowett-MSFT opened this issue Apr 8, 2020 · 0 comments · Fixed by #5289
Closed

TerminalCore/TerminalControl dispatch five billion cursor update coroutines when printing long file #5288

DHowett-MSFT opened this issue Apr 8, 2020 · 0 comments · Fixed by #5289
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Blocking We won't ship a release like this! No-siree.

Comments

@DHowett-MSFT
Copy link
Contributor

When we're printing a long file, we call winrt::fire_and_forget TermControl::_TerminalCursorPositionChanged() an absolutely mad number of times. Each one of them unconditionally dispatches and waits to tell the TSF input control it's ready to dispatch a cursor update.

We can probably do this only once per dispatcher cycle.
@DHowett-MSFT DHowett-MSFT added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. Priority-0 Bugs that we consider release-blocking/recall-class (P0) labels Apr 8, 2020
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Apr 8, 2020
DHowett-MSFT pushed a commit that referenced this issue Apr 8, 2020
@DHowett
Muffle updates to the cursor position
ee415d0 
This stops us from dispatching back-to-back terminal cursor position
updates to the TSF control before it has a chance to get back to us.

Fixes #5288.
@DHowett-MSFT DHowett-MSFT mentioned this issue Apr 8, 2020
Merged
@ghost ghost added the In-PR This issue has a related PR label Apr 8, 2020
DHowett-MSFT pushed a commit that referenced this issue Apr 9, 2020
@DHowett
Muffle updates to the cursor position to 1/~100ms (#5289)
1299a83 
This stops us from dispatching back-to-back terminal cursor position
updates to the TSF control before it has a chance to get back to us.

Fixes #5288.
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Apr 9, 2020
@skyline75489 skyline75489 mentioned this issue Apr 12, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Blocking We won't ship a release like this! No-siree.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Muffle updates to the cursor position to 1/~100ms microsoft/terminal
1 participant
@DHowett-MSFT