Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

About modal's context menu is not legible when using dark theme #3654

Closed
ducaale opened this issue Nov 21, 2019 · 5 comments · Fixed by #5224
Closed

About modal's context menu is not legible when using dark theme #3654

ducaale opened this issue Nov 21, 2019 · 5 comments · Fixed by #5224
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.0

Comments

@ducaale
Copy link

ducaale commented Nov 21, 2019 •
edited
Loading

Environment

Windows build number: 10.0.18363.476
Windows Terminal version (if applicable): 0.6.2951.0

Steps to reproduce

  1. Make sure Windows Terminal is in dark theme and Windows 10 default app mode is light
  2. Open about modal
  3. Highlight some text and right click

Expected behavior

Context menu should be legible with white text on dark background.

Actual behavior

Context menu text is not legible.

Screenshot (35)
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 21, 2019
@ducaale ducaale changed the title about modal's context menu is not legible when using dark theme About modal's context menu is not legible when using dark theme Nov 21, 2019
@AritraNath
Copy link

AritraNath commented Nov 21, 2019 •
edited
Loading

Works fine in my case....Proper legible white text.

2019-11-21 (1)

@zadjii-msft
Copy link
Member

@ducaale Did you switch to dark mode while the app was already running? Or did you launch the app in dark mode?

@zadjii-msft zadjii-msft added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Product-Terminal The new Windows Terminal. labels Nov 21, 2019
@ducaale
Copy link
Author

ducaale commented Nov 21, 2019

@zadjii-msft I launched the app in dark mode.

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Nov 21, 2019
@ducaale
Copy link
Author

ducaale commented Nov 21, 2019

@AaChristian it seems that the color of text depends on the theme of windows and not on the theme of the terminal. the context menu is legible when windows default app mode is dark

Screenshot (42)

@DHowett-MSFT DHowett-MSFT added Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. and removed Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Nov 21, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Nov 21, 2019
@DHowett-MSFT DHowett-MSFT added this to the Terminal v1.0 milestone Nov 21, 2019
@DHowett-MSFT DHowett-MSFT added the Priority-3 A description (P3) label Nov 21, 2019
@zadjii-msft zadjii-msft mentioned this issue Nov 26, 2019
Closed
DHowett-MSFT pushed a commit that referenced this issue Apr 2, 2020
@DHowett
Force all our dialogs into the application theme
a48bff8 
Because we cannot set RequestedTheme at the application level, we
occasionally run into issues where parts of our UI end up themed
incorrectly.  Dialogs, for example, live under a different Xaml root
element than the rest of our application. This makes our popup menus and
buttons "disappear" when the user wants Terminal to be in a different
theme than the rest of the system.  This hack---and it _is_ a
hack--walks up a dialog's ancestry and forces the theme on each element
up to the root. We're relying a bit on Xaml's implementation details
here, but it does have the desired effect.

It's not enough to set the theme on the dialog alone.

Fixes #3654.
Fixes #5195.
@DHowett-MSFT DHowett-MSFT mentioned this issue Apr 2, 2020
Merged
@ghost ghost added the In-PR This issue has a related PR label Apr 2, 2020
@DHowett-MSFT DHowett-MSFT mentioned this issue Apr 3, 2020
Closed
@ghost ghost closed this as completed in #5224 Apr 3, 2020
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Apr 3, 2020
ghost pushed a commit that referenced this issue Apr 3, 2020
@DHowett
Force all our dialogs into the application theme, forcibly (#5224)
9513d54 
Because we cannot set RequestedTheme at the application level, we
occasionally run into issues where parts of our UI end up themed
incorrectly.  Dialogs, for example, live under a different Xaml root
element than the rest of our application. This makes our popup menus and
buttons "disappear" when the user wants Terminal to be in a different
theme than the rest of the system.  This hack---and it _is_ a
hack--walks up a dialog's ancestry and forces the theme on each element
up to the root. We're relying a bit on Xaml's implementation details
here, but it does have the desired effect.

It's not enough to set the theme on the dialog alone.

Fixes #3654.
Fixes #5195.
@ghost
Copy link

ghost commented Apr 22, 2020

🎉This issue was addressed in #5224, which has now been successfully released as Windows Terminal Preview v0.11.1121.0.:tada:

Handy links:

@DHowett DHowett mentioned this issue Dec 1, 2020
Closed
@aquinn39 aquinn39 mentioned this issue Jul 23, 2022
Open
2 tasks
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.0
Development

Successfully merging a pull request may close this issue.

Force all our dialogs into the application theme, forcibly microsoft/terminal
5 participants
@DHowett-MSFT @ducaale @zadjii-msft @AritraNath @cinnamon-msft