Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown menu no longer displays bound keys (after #3391) #3603

Closed
DHowett-MSFT opened this issue Nov 16, 2019 · 0 comments · Fixed by #3618
Closed

Dropdown menu no longer displays bound keys (after #3391) #3603

DHowett-MSFT opened this issue Nov 16, 2019 · 0 comments · Fixed by #3618
Assignees
@zadjii-msft
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal-1911

Comments

@DHowett-MSFT
Copy link
Contributor

This no longer works on 0.6.3181.0; possible regression from #3391?

image

If I write a new binding with the legacy name newTabProfile3, I get this:

image
@DHowett-MSFT DHowett-MSFT added Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. labels Nov 16, 2019
@DHowett-MSFT DHowett-MSFT added this to the Terminal-1911 milestone Nov 16, 2019
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Nov 16, 2019
@zadjii-msft zadjii-msft self-assigned this Nov 18, 2019
zadjii-msft added a commit that referenced this issue Nov 18, 2019
@zadjii-msft
fixes #3603 by searching for ActionAndArgs too
e5db9b9
@zadjii-msft zadjii-msft mentioned this issue Nov 18, 2019
Merged
3 tasks
@ghost ghost added the In-PR This issue has a related PR label Nov 18, 2019
@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Nov 18, 2019
@ghost ghost removed the Help Wanted We encourage anyone to jump in on these. label Nov 18, 2019
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Nov 21, 2019
zadjii-msft added a commit that referenced this issue Nov 21, 2019
@zadjii-msft @carlos-zamora
Re-add keybindings to new tab dropdown (#3618)
71debc1 
## Summary of the Pull Request

With #3391, I almost certainly regressed the ability for the new tab dropdown to display the keybindings for each profile. This adds them back.

## PR Checklist
* [x] Closes #3603
* [x] I work here
* [ ] Tests added/passed
* [n/a] Requires documentation to be updated

## Detailed Description of the Pull Request / Additional comments

Now, we can lookup keybindings not only for `ShortcutAction`s, but also `ActionAndArgs`s, so we can look up the binding for an action with a particular set of arguments.
---------------------------------------------
* fixes #3603 by searching for ActionAndArgs too

* Apply suggestions from code review

Co-Authored-By: Carlos Zamora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zadjii-msft zadjii-msft

Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal-1911
Development

Successfully merging a pull request may close this issue.

Re-add keybindings to new tab dropdown microsoft/terminal
2 participants
@DHowett-MSFT @zadjii-msft