Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Tab Menu Customization SUI Follow-ups #18281

Open
2 of 6 tasks
carlos-zamora opened this issue Dec 3, 2024 · 1 comment
Open
2 of 6 tasks

New Tab Menu Customization SUI Follow-ups #18281

carlos-zamora opened this issue Dec 3, 2024 · 1 comment
Assignees
@carlos-zamora
Labels
Area-SettingsUI Anything specific to the SUI Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Milestone
Terminal v1.23

Comments

@carlos-zamora
Copy link
Member

carlos-zamora commented Dec 3, 2024 •
edited
Loading

Follow-ups from #18015:

Windows 10

Image

Bug bash 1/21 notes

  • narrow window can cut off buttons
    Image
@carlos-zamora carlos-zamora added this to the Terminal v1.23 milestone Dec 3, 2024
@carlos-zamora carlos-zamora self-assigned this Dec 3, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Dec 3, 2024
@carlos-zamora carlos-zamora added Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. Area-SettingsUI Anything specific to the SUI and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Dec 5, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Jan 6, 2025
@carlos-zamora carlos-zamora mentioned this issue Jan 14, 2025
Merged
DHowett pushed a commit that referenced this issue Jan 22, 2025
@carlos-zamora
[Windows 10] Fix layout in New Tab Menu page (#18424)
51e21dd 
There's an existing WinUI bug where a nested Grid has it's star-sizing
ignored on Windows 10. This resulted in the New Tab Menu page looking
weird on Windows 10. This PR fixes the layout issue by applying a max
width to the first column, which will be clipped as necessary to make
space for the second column.

Part of #18281

## Validation Steps Performed
Validated the page looks good on Windows 10 and Windows 11, even after
resizing the window.
@AdrianoCahete
Copy link

Using this issue instead of creating another:

Took me a while to understand that the "Folder" here is a group. My first thinking was that I could open/map a folder from that link...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlos-zamora carlos-zamora

Labels
Area-SettingsUI Anything specific to the SUI Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal v1.23
Development

No branches or pull requests
2 participants
@AdrianoCahete @carlos-zamora