Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PGO has been "at a farm upstate" since VS 2022 #13500

Closed
DHowett opened this issue Jul 13, 2022 · 5 comments · Fixed by #13502
Closed

PGO has been "at a farm upstate" since VS 2022 #13500

DHowett opened this issue Jul 13, 2022 · 5 comments · Fixed by #13502
Labels
Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@DHowett
Copy link
Member

DHowett commented Jul 13, 2022

image

There are only five commits in that range, and not one of them might explain what is happening better than the VS 2022 one.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 13, 2022
@zadjii-msft zadjii-msft mentioned this issue Jul 13, 2022
Closed
@DHowett
Copy link
Member Author

DHowett commented Jul 13, 2022

Fortunately Helix gives us dumps

and this one looks like "I couldn't load TerminalApp.dll, yo"

0b 00000018`9ff5f450 00007ff6`bff0e91d     WindowsTerminal!winrt::throw_hresult+0x3ba [C:\a\_work\1\s\src\cascadia\WindowsTerminal\Generated Files\winrt\base.h @ 4946] 
0c 00000018`9ff5f4b0 00007ff6`bff0ebbe     WindowsTerminal!winrt::check_hresult+0x2d [C:\a\_work\1\s\src\cascadia\WindowsTerminal\Generated Files\winrt\base.h @ 5016] 
0d 00000018`9ff5f4f0 00007ff6`bff30f9e     WindowsTerminal!winrt::get_activation_factory<winrt::Windows::Foundation::IActivationFactory>+0x7e [C:\a\_work\1\s\src\cascadia\WindowsTerminal\Generated Files\winrt\base.h @ 6039] 
0e 00000018`9ff5f550 00007ff6`bff232fb     WindowsTerminal!winrt::impl::factory_cache_entry<winrt::TerminalApp::App,winrt::Windows::Foundation::IActivationFactory>::call<winrt::TerminalApp::App (__cdecl*)(winrt::Windows::Foundation::IActivationFactory const &)>+0x9e [C:\a\_work\1\s\src\cascadia\WindowsTerminal\Generated Files\winrt\base.h @ 6266] 
0f 00000018`9ff5f600 00007ff6`bff24aa9     WindowsTerminal!winrt::impl::call_factory_cast<winrt::TerminalApp::App (__cdecl*)(winrt::Windows::Foundation::IActivationFactory const &),winrt::TerminalApp::App,winrt::Windows::Foundation::IActivationFactory,`winrt::TerminalApp::App::App'::`1'::<lambda_164_> >+0xab [C:\a\_work\1\s\src\cascadia\WindowsTerminal\Generated Files\winrt\base.h @ 6325] 
10 00000018`9ff5f640 00007ff6`bff34f73     WindowsTerminal!winrt::TerminalApp::App::App+0x39 [C:\a\_work\1\s\src\cascadia\WindowsTerminal\Generated Files\winrt\TerminalApp.h @ 6090] 
11 00000018`9ff5f680 00007ff6`bff2e913     WindowsTerminal!AppHost::AppHost+0x63 [C:\a\_work\1\s\src\cascadia\WindowsTerminal\AppHost.cpp @ 32] 
12 00000018`9ff5f760 00007ff6`bff27fe2     WindowsTerminal!wWinMain+0x183 [C:\a\_work\1\s\src\cascadia\WindowsTerminal\main.cpp @ 139]

@DHowett
Copy link
Member Author

DHowett commented Jul 13, 2022

It loads properly on Windows 11 SV2...

Time to unearth the Vb VM

@DHowett
Copy link
Member Author

DHowett commented Jul 13, 2022

It... doesn't fail on the VB VM. Oh man.

@DHowett
Copy link
Member Author

DHowett commented Jul 13, 2022

I'm guessing that the Helix machines have an old version of the VC++ redist that is missing msvcp140_atomic_wait.dll

@DHowett
Copy link
Member Author

DHowett commented Jul 13, 2022

https://microsoft.visualstudio.com/Dart/_build/results?buildId=52437427&view=results

@DHowett DHowett mentioned this issue Jul 14, 2022
Merged
@ghost ghost added the In-PR This issue has a related PR label Jul 14, 2022
@ghost ghost closed this as completed in #13502 Jul 14, 2022
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Jul 14, 2022
ghost pushed a commit that referenced this issue Jul 14, 2022
@DHowett
Fix PGO by "installing" a newer version of VCLibs to our app folder (#…
ae9532f 
…13502)

Moving to VS 2022 and C++20 in #13368 introduced a new dependency on an
as-yet-nonexistent VC Runtime library: msvcp140_atomic_wait.dll. That
library is not installed on the 21H1 machines that run our PGO tests.

Fortunately, the app platform will--largely--handle this dependency for
us on machines in the wild.

Fixes #13500
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix PGO by "installing" a newer version of VCLibs to our app folder microsoft/terminal
1 participant
@DHowett