Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command palette goes to the top when you go back (<) from a submenu #13457

Closed
vefatica opened this issue Jul 7, 2022 · 6 comments · Fixed by #13504
Closed

Command palette goes to the top when you go back (<) from a submenu #13457

vefatica opened this issue Jul 7, 2022 · 6 comments · Fixed by #13504
Labels
Area-CmdPal Command Palette issues and features good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Backlog

Comments

@vefatica
Copy link

vefatica commented Jul 7, 2022

As the subject says, if I open a submenu of the command palette (e.g., "New tab") and go back via the <-button, I'm back at the top of the command palette. I'd prefer to be back where I was. It's not a bug, but the bahavior could be made more friendly.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 7, 2022
@zadjii-msft
Copy link
Member

Hmm this is in #5400, I'm pretty sure it's a full issue somewhere too

The "go back" button should pop only one layer of the stack, not go all the way back to the root (#8051 (comment))

@vefatica
Copy link
Author

vefatica commented Jul 7, 2022

I guess that's a matter of terminology. The actual behavior and my desired behavior both go back to the command palette. It's the position in the command palette after going back that concerns me ... back to the beginning of the command palette or back to where I was.

@zadjii-msft zadjii-msft added Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. Priority-3 A description (P3) good first issue This is a fix that might be easier for someone to do as a first contribution Area-CmdPal Command Palette issues and features labels Jul 8, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 8, 2022
@zadjii-msft zadjii-msft added Help Wanted We encourage anyone to jump in on these. Needs-Tag-Fix Doesn't match tag requirements labels Jul 8, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 8, 2022
@zadjii-msft zadjii-msft added this to the Backlog milestone Jul 8, 2022
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 8, 2022
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Jul 8, 2022
@zadjii-msft zadjii-msft mentioned this issue Jul 8, 2022
Open
52 tasks
@JerBast
Copy link
Contributor

JerBast commented Jul 13, 2022

@zadjii-msft, I would be happy to work on this as my first contribution to this repo (if possible). I assume the desired result is to focus the filtered view to the previously selected item when returning from a nested collection?

image

@zadjii-msft
Copy link
Member

That's what I would do, yea! Lemme know if you have any questions. This line:

terminal/src/cascadia/TerminalApp/CommandPalette.cpp

Line 539 in 574a72b

_nestedActionStack.Clear();
is where I'd start ☺️

@JerBast JerBast mentioned this issue Jul 14, 2022
Merged
@ghost ghost added the In-PR This issue has a related PR label Jul 14, 2022
@ghost ghost closed this as completed in #13504 Jul 19, 2022
ghost pushed a commit that referenced this issue Jul 19, 2022
@JerBast
Make cmd palette 'go back' button return to previously selected action (
0337869 
#13504)

The behaviour of the 'go back' button in the command palette was changed to return to the previously selected element rather than the root.

Instead of returning to the root, the go back button now returns to the previously selected item in the filtered action list. The previously selected item is selected by default and the view is scoped to the item.

## Validation Steps Performed
Manually tested by going back and forth between nested actions in the command palette.

Closes #13457
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Jul 19, 2022
@ghost
Copy link

ghost commented Sep 13, 2022

🎉This issue was addressed in #13504, which has now been successfully released as Windows Terminal Preview v1.16.252.:tada:

Handy links:

@vefatica
Copy link
Author

I just got this one:

"Microsoft.WindowsTerminalPreview_Win10_1.16.2523.0_8wekyb3d8bbwe.msixbundle"

or maybe it's this one:

WindowsTerminalPreview 1.16.2209.09003

Is that one Windows Terminal Preview v1.16.252?

It has too many version descriptions!

The back button works as desired. I didn't mention it earlier but I'd expect Esc to do the same thing (i.e., go back) but it just closes the command palette.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-CmdPal Command Palette issues and features good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Make cmd palette 'go back' button return to previously selected action JerBast/terminal
3 participants
@zadjii-msft @JerBast @vefatica