Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vietnamese IME word composition bug #11479

Closed
ducminh03 opened this issue Oct 11, 2021 · 1 comment · Fixed by #13678
Closed

Vietnamese IME word composition bug #11479

ducminh03 opened this issue Oct 11, 2021 · 1 comment · Fixed by #13678
Assignees
@lhecker
Labels
Area-i18n Internationalization issues (e.g.: non-US input handling doesn't work) Area-Input Related to input processing (key presses, mouse, etc.) Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
22H2

Comments

@ducminh03
Copy link

Windows Terminal version (or Windows build number)

Windows Terminal 1.10.2714.0

Other Software

  • Microsoft Windows [Version 10.0.22000.194] (though I believe this also occurs back to Windows 10 1903, which is the first version of Windows where Vietnamese Telex IME is first introduced)
  • Powershell 7.1.4 (x64)

Steps to reproduce

  1. Add the Vietnamese language and 'Vietnamese Telex' keyboard layout
  2. Open Windows Terminal, then switch to PowerShell
  3. Switch to Vietnamese Telex keyboard layout
  4. Type 'Xin chaof' (including the apostrophe) then press Enter

Expected Behavior

The sentence 'Xin chào' is written to the console, with normal word composition. (The screenshot is took in conhost)
conhost

(Note for non-Vietnamese: the 'f' denotes the grave on the main vowel, which, in this case, is the 'a')

Actual Behavior

The IME composition works normally for the first syllable Xin. However, after pressing the 'c', the IME suddenly sticks the previous syllable at the beginning when composing, which breaks normal Vietnamese syllable structure. Therefore, when pressing the letter 'f', the IME then decides to append an 'f' instead of putting a grave on the 'a'. All of these result in the output of 'Xin Xinchaof'.
wt

Somehow when composing the following words, the keystroke of the previous composition is retained. After typing Xin, then pressing Space and the 'f', the grave is put on the 'i' of the previous syllable 'Xin':
wt

The problem seems to come from the IME itself, since it is a relatively new piece of software. However, it would be nice to explain why the problem does not occur on conhost.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Oct 11, 2021
@zadjii-msft zadjii-msft added the Product-Terminal The new Windows Terminal. label Oct 13, 2021
@zadjii-msft zadjii-msft added Area-i18n Internationalization issues (e.g.: non-US input handling doesn't work) Area-Input Related to input processing (key presses, mouse, etc.) Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) labels Jan 21, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jan 21, 2022
@zadjii-msft zadjii-msft added this to the 22H1 milestone Jan 21, 2022
@zadjii-msft zadjii-msft modified the milestones: 22H1, Terminal v1.14 Feb 2, 2022
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Feb 14, 2022
@zadjii-msft zadjii-msft modified the milestones: Terminal v1.14, 22H2 Mar 10, 2022
@lhecker lhecker self-assigned this Mar 15, 2022
This was referenced Aug 4, 2022
Closed
Merged
@ghost ghost added the In-PR This issue has a related PR label Aug 4, 2022
@ghost ghost closed this as completed in #13678 Aug 11, 2022
ghost pushed a commit that referenced this issue Aug 11, 2022
@lhecker
Fix issues with Japanese & Vietnamese IME (#13678)
ed800dc 
This commit builds directly on the changes made in #13677 and fixes:
* TSF resetting to AlphaNumeric ("ASCII") input mode when pressing enter
* Vietnamese IME not composing a new word after pressing whitespace, etc.

Closes #11479
Closes #13398

## Validation Steps Performed
* Japanese IME (Full-Width Katakana)
  Typing "saitama" produces "サイタマ" ✅
* Korean IME
  Typing "gksrmf" produces "한글" ✅
* Vietnamese IME
  Typing "xin chaof" produces "xin chào" ✅
* Emoji Picker (Win+.)
  ✅
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Aug 11, 2022
@ghost
Copy link

ghost commented Aug 17, 2022

🎉This issue was addressed in #13678, which has now been successfully released as Windows Terminal Preview v1.15.228.:tada:

Handy links:

PKRoma pushed a commit to PKRoma/Terminal that referenced this issue Oct 15, 2022
@lhecker @DHowett
Fix issues with Japanese & Vietnamese IME (microsoft#13678)
22edbc1 
This commit builds directly on the changes made in microsoft#13677 and fixes:
* TSF resetting to AlphaNumeric ("ASCII") input mode when pressing enter
* Vietnamese IME not composing a new word after pressing whitespace, etc.

Closes microsoft#11479
Closes microsoft#13398

## Validation Steps Performed
* Japanese IME (Full-Width Katakana)
  Typing "saitama" produces "サイタマ" ✅
* Korean IME
  Typing "gksrmf" produces "한글" ✅
* Vietnamese IME
  Typing "xin chaof" produces "xin chào" ✅
* Emoji Picker (Win+.)
  ✅

(cherry picked from commit ed800dc)
Service-Card-Id: 84832470
Service-Version: 1.15
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lhecker lhecker

Labels
Area-i18n Internationalization issues (e.g.: non-US input handling doesn't work) Area-Input Related to input processing (key presses, mouse, etc.) Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
22H2
Development

Successfully merging a pull request may close this issue.

Fix issues with Japanese & Vietnamese IME microsoft/terminal
4 participants
@DHowett @lhecker @ducminh03 @zadjii-msft