General: typing "state.conversation.value.field" is too long. Remove the ".value" #49
Assignees
Labels
breaking-change
This enhancement would be a breaking change
enhancement
New feature or request
JS & dotnet & Python
Change or fix must apply to all three programming languages
Milestone
Comments
Stevenic
added
enhancement
|
Idea: What do you think about state.convo.field? matches state.user.field and state.temp.field in length |
|
Moving this milestone to //BUILD since it is not a blocker for private preview |
corinagum
added
the
JS & dotnet & Python
|
P0 |
Closed
|
Finished with #667 |
corinagum
added a commit
that referenced
this issue
Sep 13, 2024
…#2014) ## Linked issues closes: #1947 closes #1371 #### TLDR: Node 20 is now supported!!! If you're eager for this, you shouldn't need to wait for a release, as the affected packages were our samples. ## Details - Modified package configuration for `typescript` to only allow patch updates. See Change details below for more information. This is (ideally) temporary. - Remove `@microsoft/teamsfx` as a dependency - it turns out this dependency is entirely unused, but due to sub-dependencies was preventing us from being able to support Node >=18. Because of this and `[email protected]` now supporting node 20, teams-ai js package now also runs with node 20 too! - Removed `browserify` - unused dependency - Updated Powered by AI docs to slightly clarify how AI module may use a `planner`. #### Change details [TS made an update](https://devblogs.microsoft.com/typescript/announcing-typescript-5-6) that in 5.6 reveals previously 'hidden' TS errors. `gpt-tokenizer` and `botbuilder` have TS errors that 5.6 catches. I filed bugs for both packages: [[Bug] Cannot upgrade to TS 5.6x due to build errors · Issue #49 · niieani/gpt-tokenizer (github.com)](niieani/gpt-tokenizer#49) [Cannot bump typescript to 5.6 due to botbuilder `INodeBuffer` error · Issue #4746 · microsoft/botbuilder-js (github.com)](microsoft/botbuilder-js#4746) ## Attestation Checklist - [x] My code follows the style guidelines of this project - I have checked for/fixed spelling, linting, and other errors - I have commented my code for clarity - I have made corresponding changes to the documentation (updating the doc strings in the code is sufficient) - My changes generate no new warnings - I have added tests that validates my changes, and provides sufficient test coverage. I have tested with: - Local testing - E2E testing in Teams - New and existing unit tests pass locally with my changes ### Additional information > Feel free to add other relevant information below --------- Co-authored-by: Corina Gum <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently it feels pretty cumbersome to have to type
state.conversation.value.fieldall the time. The.valueseems like an unneeded step. It's there because there are a series of management operations. I'd like to try flipping the relationship such that management functions are nested under a.__manageproperty that hangs off the scope. That would mean that developers can usestate.conversation.fieldto access their state properties andstate.conversation.__manage.delete()to delete the current state.The text was updated successfully, but these errors were encountered: