fall back to master when connected to secondary

[shueybubbles]

If the database name in the connection string doesn't match any database found in sys.databases, fall back to master for the database node in Object Explorer.

[ranasaria]

Is the fallback to master a feature of SSMS currently?

[shueybubbles]

SSMS doesn't have this issue because its object explorer root is not database-scoped. It always displays the full result of sys.databases query regardless of whether the connection string has an initial catalog.

[ranasaria]

Is this behavior change a good change then? I worry that this might surprise (not necessarily pleasantly) the user. Consider a scenario where a user has database1, database2 and master on her server. Further assume that that database1 is production, database2 is pre-production and master is her development test instance, so all there has same user database objects and schema. Now when she mistypes database1 and database2 in her connection strings to db1 and db2 or some such, she silently gets connected to master and she may not realize that this has happened for quite some time since a lot of child nodes on the database would have the object that she expects!

[shueybubbles]

if "initial catalog=somename" is in the string, and "somename" doesn't exist on the server at all, the connection attempt itself will fail.
if "somename" refers to the readable secondary master, the connection will succeed, but queries to sys.databases won't return "somename".

[shueybubbles]

ie we still get this dialog: System.Data.SqlClient.SqlException (0x80131904): Cannot open database "myfunky" requested by the login. The login failed.
Login failed for user 'user'.
at System.Data.SqlClient.SqlInternalConnectionTds..ctor(DbConnectionPoolIdentity identity, SqlConnectionString connectionOptions, SqlCredential credential, Object providerInfo, String newPassword, SecureString newSecurePassword, Boolean redirectedUserInstance,

[ranasaria]

[kevcunnane]

Looks great. and then let's get a build to release it so we can pull into latest Insiders. Thanks David!

[coveralls]

Coverage increased (+4.06%) to 76.802% when pulling ca94070 on readablesecond into b01bdeb on master.