Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix decimal datatype handling #1352

Merged
merged 6 commits into from
Jan 4, 2022
Merged

fix decimal datatype handling #1352

merged 6 commits into from
Jan 4, 2022

Conversation

alanrenmsft
Copy link
Contributor

  1. undo the revert of my previous PRs while we were doing the Dec release, my previous PRs: handle large decimal #1326 and handle sql variable type #1333
  2. and fixed the money type handling that was found during the Dec release.
  3. added test cases for all types.

the PR fixes: microsoft/azuredatastudio#275

@alanrenmsft alanrenmsft merged commit 995e9ba into main Jan 4, 2022
@alanrenmsft alanrenmsft deleted the alanren/data-reader branch January 4, 2022 21:56
nofield pushed a commit that referenced this pull request Jul 19, 2022
@alanrenmsft @nofield
fix decimal datatype handling (#1352)
d2fc33a 
* Revert "Revert query execution changes (#1341)"

This reverts commit cb290cd.

* fix decimal and money

* timestamp

* fix code and tests

* add sql variant test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Charles-Gagnon Charles-Gagnon Charles-Gagnon approved these changes

@kburtram kburtram Awaiting requested review from kburtram

@Benjin Benjin Awaiting requested review from Benjin

@llali llali Awaiting requested review from llali

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error with displaying results in sqlops - Query failed: Conversion overflows.
2 participants
@alanrenmsft @Charles-Gagnon