Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ARM 32 bits build, prfm is a 64 bits instruction. #263

Merged
merged 1 commit into from
Dec 2, 2020

Conversation

devnexen
Copy link
Collaborator

No description provided.

@mjp41
Copy link
Member

mjp41 commented Nov 30, 2020

Do you know why the ARM 32-bit CI was not failing? What should we change on that pipeline?

@devnexen
Copy link
Collaborator Author

I do not really know azure pipelines, I do not know if the 32 bits build are genuine 32 bits or labels ?
Anyway I was just testing the build on a raspberry.

@davidchisnall
Copy link
Collaborator

@devnexen, what's the compiler that you're using? I think we'll probably use __builtin_prefetch() with clang and only use this version on gcc Arm. We might want to expand the CI to try gcc on the Arm builds.

@devnexen
Copy link
Collaborator Author

ah right I did not notice but I was using gcc indeed :)

@mjp41 mjp41 merged commit 3e7ea1a into microsoft:master Dec 2, 2020
@mjp41
Copy link
Member

mjp41 commented Dec 2, 2020

@devnexen, thanks for fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants