-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Haiku debug build, rdynamic flag unsupported. #247
Conversation
CMakeLists.txt
Outdated
@@ -175,10 +175,10 @@ if(NOT DEFINED SNMALLOC_ONLY_HEADER_LIBRARY) | |||
# Static TLS model unsupported on Haiku |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind updating this comment while you're at it?
3842a94
to
1d964a6
Compare
Is this just a compiler driver bug? Does -Wl,-rdynamic work? If so, that should work everywhere and we can fix at least the clang driver to forward -rdynamic to the linker quite easily to prevent this being a problem for other projects in the future. |
It s really unsupported (even what you propose). |
That’s surprising. -rdynamic just puts everything in the dynamic symbol table. I don’t see how you can have an ELF target that supports shared libraries and doesn’t support it. |
All symbols are exported by default on Haiku, it is |
I see, so |
I think I updated the comment in CMakeLists.txt earlier |
CMakeLists.txt
Outdated
@@ -172,13 +172,13 @@ if(NOT DEFINED SNMALLOC_ONLY_HEADER_LIBRARY) | |||
set(CMAKE_EXE_LINKER_FLAGS_RELEASE "${CMAKE_EXE_LINKER_FLAGS_RELEASE} /DEBUG") | |||
else() | |||
add_compile_options(-fno-exceptions -fno-rtti -g -fomit-frame-pointer) | |||
# Static TLS model unsupported on Haiku | |||
# Static TLS model and -rdynamic flag (always -shared) are unsupported on Haiku |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Static TLS model and -rdynamic flag (always -shared) are unsupported on Haiku | |
# Static TLS model is unsupported on Haiku. | |
# All symbols are always dynamic on Haiku and so -rdynamic is redundant (and unsupported). |
1d964a6
to
b43380a
Compare
No description provided.