Don't require 16-byte CAS on x86. #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only need to CAS 2 pointers, which is always possible on x86.
achamayou
reviewed
Apr 15, 2020
azure-pipelines.yml
Outdated
| BuildType: Debug | ||
| SelfHost: false | ||
| CMakeArgs: '' | ||
| Image: plietar/snmalloc-build_linux_x86:latest |
There was a problem hiding this comment.
I'll add you to snmallocciteam, so you can update/replace images there.
achamayou
reviewed
Apr 15, 2020
src/ds/aba.h
Outdated
| @@ -99,9 +99,10 @@ namespace snmalloc | |||
| (__int64)value, | |||
| (__int64*)&old); | |||
| # else | |||
| # if defined(__GNUC__) && !defined(__GCC_HAVE_SYNC_COMPARE_AND_SWAP_16) | |||
| # if defined(__GNUC__) && defined(SNMALLOC_VA_BITS_64) && !defined(__GCC_HAVE_SYNC_COMPARE_AND_SWAP_16) | |||
There was a problem hiding this comment.
I'll try not to forget to that out in Open Enclave.
achamayou
approved these changes
Apr 15, 2020
The x86 image doesn't have clangformat, which causes cmake to print a warning on the stderr. Exit codes should be enough to detect failure.
achamayou
approved these changes
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only need to CAS 2 pointers, which is always possible on x86.
This uses the
plietar/snmalloc-build_linux_x86:latestdocker image, obviously that should be changed to something under snmallocciteam.