try to add msbuild to github workflow and add signing for third party…

… dll
microsoft · Jan 18, 2025 · af428f4 · af428f4
1 parent ce0f48b
commit af428f4
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 8 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -28,6 +28,8 @@ jobs:
     - uses: actions/checkout@v4
       with:
         fetch-depth: 0 # avoid shallow clone so nbgv can do its work.
+    - name: Setup MSBuild
+        uses: microsoft/setup-msbuild@v1
     - name: ⚙ Install prerequisites
       run: |
         ./init.ps1 -UpgradePrerequisites

diff --git a/src/Microsoft.VisualStudio.SlowCheetah/Microsoft.VisualStudio.SlowCheetah.csproj b/src/Microsoft.VisualStudio.SlowCheetah/Microsoft.VisualStudio.SlowCheetah.csproj
@@ -20,14 +20,7 @@
   </PropertyGroup>
 
 
-  <!-- Additional files for the nupkg -->
-  <ItemGroup>
-    <None Include="$(OutputPath)Microsoft.Web.XmlTransform.dll" Pack="true" PackagePath="tools" Visible="false" />
-    <None Include="$(OutputPath)Microsoft.VisualStudio.Jdt.dll" Pack="true" PackagePath="tools" Visible="false" />
-    <!-- Tevin: Test to see what this does and if it is necessary. -->
-     <None Include="$(OutputPath)Newtonsoft.Json.dll" Pack="true" PackagePath="tools" Visible="false" /> 
-  </ItemGroup>
-
+
 
   <ItemGroup>
     <None Update="Build\*.targets" Pack="true" PackagePath="build/%(Filename)%(Extension)" CopyToOutputDirectory="PreserveNewest" />
@@ -58,10 +51,27 @@
     </EmbeddedResource>
   </ItemGroup>
 
+  <ItemGroup>
+    <FilesToSign Include="$(OutputPath)Newtonsoft.Json.dll">
+      <Authenticode>3PartySHA2</Authenticode>
+      <StrongName>None</StrongName>
+    </FilesToSign>
+  </ItemGroup>
+
+  <!-- Additional files for the nupkg -->
+  <ItemGroup>
+    <None Include="$(OutputPath)Microsoft.Web.XmlTransform.dll" Pack="true" PackagePath="tools" Visible="false" />
+    <None Include="$(OutputPath)Microsoft.VisualStudio.Jdt.dll" Pack="true" PackagePath="tools" Visible="false" />
+    <!-- Tevin: Test to see what this does and if it is necessary. -->
+    <None Include="$(OutputPath)Newtonsoft.Json.dll" Pack="true" PackagePath="tools" Visible="false" />
+  </ItemGroup>
+
+
   <ItemDefinitionGroup>
     <PackageReference>
       <PrivateAssets>all</PrivateAssets>
     </PackageReference>
   </ItemDefinitionGroup>
+
 
 </Project>