Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper string comparison for directory root to capture relative paths #579

Merged

Conversation

mruxmohan4
Copy link
Contributor

@mruxmohan4 mruxmohan4 commented Mar 7, 2024

For directory roots that differ in casing (ex: C:\\ vs c:\\), absolute instead of relative paths will appear in the solution. This change addresses that by adding a string comparison and checking the path root (drive) for the absolute root path against the folder's path root before determining whether to emit a warning (note: this will limit the scenarios where a warning is emitted).

This should help with cases where absolute paths are seen instead of relative paths, for example:
Project("{<guid>}") = "tests", "C:\projects\slngen-test\src\core\App1\tests", "{<guid>}"

Should now become:
Project("{<guid>}") = "tests", "src\core\App1\tests", "{<guid>}"

Addresses #578

@mruxmohan4 mruxmohan4 force-pushed the dev/mruxmohan/fix-drive-warning branch 3 times, most recently from b2f341d to cd17041 Compare March 7, 2024 22:57
@mruxmohan4 mruxmohan4 force-pushed the dev/mruxmohan/fix-drive-warning branch from cd17041 to 949ea01 Compare March 8, 2024 00:55
@mruxmohan4 mruxmohan4 merged commit 2dca73e into microsoft:main Mar 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant