Use proper string comparison for directory root to capture relative paths #579
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For directory roots that differ in casing (ex:
C:\\
vsc:\\
), absolute instead of relative paths will appear in the solution. This change addresses that by adding a string comparison and checking the path root (drive) for the absolute root path against the folder's path root before determining whether to emit a warning (note: this will limit the scenarios where a warning is emitted).This should help with cases where absolute paths are seen instead of relative paths, for example:
Project("{<guid>}") = "tests", "C:\projects\slngen-test\src\core\App1\tests", "{<guid>}"
Should now become:
Project("{<guid>}") = "tests", "src\core\App1\tests", "{<guid>}"
Addresses #578