Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #444 Multiple projects depending on the same shared items causes an error #445

Merged

Conversation

OskiKervinen-MF
Copy link
Contributor

@OskiKervinen-MF OskiKervinen-MF commented Jan 23, 2023

When multiple projects in the graph referred to the same shared items project, it was tried to add to LoadedProjects another time, causing it to throw System.InvalidOperationException: An equivalent project (a project with the same global properties and tools version) is already present in the project collection..

Solution:
Don't call CreateProject on the imported project if it's already in LoadedProjects.

Fixes #444

@OskiKervinen-MF OskiKervinen-MF changed the title Fixed: #444 Multiple projects depending on the same shared items causes an error Fixed #444 Multiple projects depending on the same shared items causes an error Jan 27, 2023
Copy link
Collaborator

@jeffkl jeffkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jeffkl jeffkl merged commit a76f2fd into microsoft:main Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Solution generation fails when multiple projects include the same shared items project
2 participants