Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using shell execute #310

Merged
merged 1 commit into from
Nov 18, 2021
Merged

Conversation

jeffkl
Copy link
Collaborator

@jeffkl jeffkl commented Nov 18, 2021

UseShellExecute causes issues when launching process.

  • MSBuild.exe waits for devenv.exe if UseShellExecute is used
  • The Visual Studio Version Selector is launched which isn't always correct

Instead, use the instance of Visual Studio for the MSBuild.exe that was found on the PATH which is more precise

Fixes #203, related to #308

UseShellExecute causes issues when launching process.

 * MSBuild.exe waits for devenv.exe if UseShellExecute is used
* The Visual Studio Version Selector is launched which isn't always correct

Instead, use the instance of Visual Studio for the MSBuild.exe that was found on the PATH which is more precise

Fixes microsoft#203
@jeffkl jeffkl merged commit a224cf8 into microsoft:main Nov 18, 2021
@jeffkl jeffkl deleted the get-rid-of-shellexecute branch November 18, 2021 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SlnGenDevEnvFullPath holds command prompt hostage till IDE is closed
1 participant