Adding 'Previous Role' to the reconfiguration text #874
Conversation
|
could we also add a new column to the replica list for partition which shows previous replica role? this could be useful in investigation |
We can't do that, since the API used for getting previous replica role Get-ServiceFabricReplica But we can add |
|
Latest changes to the UI: Also, I need help with adjusting the CSS for replica-tile component. Tile's height doesn't automatically adjust to the added field... It looks like the relevant styles are in src\SfxWeb\src\app\modules\partition-replication\replica-status-container\replica-status-container.component.scss |
I only meant the table at the bottom, like an extra column added next to replica role |
Oh, we can do that, but like I already mentioned, we can only show previous role if a partition is undergoing a reconfig. |
my mistake I didnt see that in the previous message. |
|
|
|
@jeffj6123 @chensation After a considerable break, this PR has been revived! 😊 Please take a moment to review the most recent updates. |
|
@vpavlovicMSFT , I think my requested changes still stands. The same role logic is inside @jeffj6123 , I know your original comment said you only wanted a "Previous Role" column at the bottom table, but would you say that adding a "Previous Role" row to the Replicator Status would still make it easier to read? this particular change has been reverted, and now looks like this |
vpavlovicMSFT
force-pushed
the
master
branch
from
2c83b09 to
922b6c4
Compare
…case) (#2) * DeployedReplica role during reconfiguration * Handle when partition is undefined * Update DeployedReplica.ts * Remove empty line
|
Hi @jeffj6123 and @chensation, we addressed the requested change and adjusted the logic in |
|
@mssusnjar can you add tests into |
Currently, if a partition is undergoing reconfiguration, there is no means to determine the primary replica, as the only information available to customers via SFX is the target role of the replica. The introduction of 'Previous Role' will significantly reduce the risk of accidentally terminating the primary replica, a scenario that could potentially lead to data loss.
While a partition is undergoing reconfiguration, in addition to the 'Target Role', 'Previous Role' will also be displayed.
ADO work item