New configs #200
Merged
New configs #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan12346
requested review from
Christina-Kang,
jeffj6123 and
samedder
as code owners
jeffj6123
previously approved these changes
Oct 8, 2019
Christina-Kang
suggested changes
Oct 8, 2019
There was a problem hiding this comment.
Please add release notes in file https://github.com/microsoft/service-fabric-cli/blob/master/src/README.rst
You can add a new line under "Unreleased"
Thank you! :)
Done. |
Remove period at end of sentence
Christina-Kang
approved these changes
Oct 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Changes include:
-Added ServicePlacementTimeLimit parameter to UpdateService and to CreateService, as part of StatefulServiceDescription
-Added VeryHighMoveCost value for MoveCost.
-Added tests
Verified: