Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement central package management #127

Merged
merged 5 commits into from
Nov 19, 2024
Merged

Implement central package management #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8a3c1cd
Implement central package versioning
plave0 Nov 18, 2024
64295b0
Migrate test projects to central package versioning
plave0 Nov 18, 2024
c7e2d4c
Disable unused NuGet projects
plave0 Nov 18, 2024
28b0831
Disable unused NuGet projects
plave0 Nov 18, 2024
d6d82c1
Remove TODO tags from Directory.Packages.props
plave0 Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
<Project>
plave0 marked this conversation as resolved.
Show resolved Hide resolved
<PropertyGroup>
<ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
<CentralPackageTransitivePinningEnabled>true</CentralPackageTransitivePinningEnabled>
</PropertyGroup>

<!-- Sort packages by name to reduce merge conflicts -->

<!-- Versions of some transitive dependencies have been overwritten due the the fact that
they have been marked as vulnerable. -->

<!-- Each time direct dependecies are updated, the transitive
dependencies should be revised to see if overwriting their version is still necessary.-->

<ItemGroup>
<PackageVersion Include="FluentAssertions" Version="6.12.0" />
<PackageVersion Include="Microsoft.AspNetCore.Hosting" Version="2.1.1" />
<PackageVersion Include="Microsoft.AspNetCore.Http" Version="2.1.34" /> <!-- Transitive dependecy -->
<PackageVersion Include="Microsoft.AspNetCore.Server.HttpSys" Version="2.1.12" />
<PackageVersion Include="Microsoft.AspNetCore.Server.Kestrel" Version="2.1.3" />
<PackageVersion Include="Microsoft.AspNetCore.Server.Kestrel.Core" Version="2.1.25" /> <!-- Transitive dependecy -->
<PackageVersion Include="Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets" Version="2.1.40" /> <!-- Transitive dependecy -->
<PackageVersion Include="Microsoft.Extensions.Configuration" Version="2.1.1" />
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.10.0" />
<PackageVersion Include="Microsoft.ServiceFabric" Version="11.0.1004" />
<PackageVersion Include="Microsoft.ServiceFabric.Services" Version="8.0.1004" />
<PackageVersion Include="Moq" Version="4.20.70" />
<PackageVersion Include="System.IO.Pipelines" Version="8.0.0" /> <!-- Transitive dependecy -->
<PackageVersion Include="System.Text.Encodings.Web" Version="8.0.0" /> <!-- Transitive dependecy -->
<PackageVersion Include="StyleCop.Analyzers" Version="1.1.118" />
<PackageVersion Include="xunit" Version="2.8.1" />
<PackageVersion Include="xunit.runner.visualstudio" Version="2.8.1" />
</ItemGroup>
</Project>
80 changes: 0 additions & 80 deletions ...viceFabric.AspNetCore.Abstractions/Microsoft.ServiceFabric.AspNetCore.Abstractions.nuproj
View file
Open in desktop

This file was deleted.

81 changes: 0 additions & 81 deletions ...ceFabric.AspNetCore.Configuration/Microsoft.ServiceFabric.AspNetCore.Configuration.nuproj
View file
Open in desktop

This file was deleted.

81 changes: 0 additions & 81 deletions ...rosoft.ServiceFabric.AspNetCore.HttpSys/Microsoft.ServiceFabric.AspNetCore.HttpSys.nuproj
View file
Open in desktop

This file was deleted.

81 changes: 0 additions & 81 deletions ...rosoft.ServiceFabric.AspNetCore.Kestrel/Microsoft.ServiceFabric.AspNetCore.Kestrel.nuproj
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions properties/service_fabric_common.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,6 @@
<!-- Set Nuget exe path -->
<NuGetExePath Condition="'$(NuGetExePath)' == ''">$(RepoRoot)\nuget\nuget.exe</NuGetExePath>

<!-- Versions used for Microsoft.ServiceFabric.* nuget packages from other repos.-->
<NugetPkg_Version_Microsoft_ServiceFabric>11.0.1004</NugetPkg_Version_Microsoft_ServiceFabric>
<NugetPkg_Version_Microsoft_ServiceFabric_Services>8.0.1004</NugetPkg_Version_Microsoft_ServiceFabric_Services>

<!-- Set versions for files and nuget packages nuget packages generated from this repo. -->
<!-- TODO: Versions numbers are changed here manually for now, Integrate this with GitVersion. -->
<MajorVersion>8</MajorVersion>
Expand Down
2 changes: 1 addition & 1 deletion properties/service_fabric_managed_stylecop.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<StylecopSuppressionsFile>$(MSBuildThisFileDirectory)stylecop\StylecopSuppressions.cs</StylecopSuppressionsFile>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="StyleCop.Analyzers" Version="1.1.118" />
<PackageReference Include="StyleCop.Analyzers"/>
</ItemGroup>
<ItemGroup>
<None Remove="$(StylecopSettingsFile)" />
Expand Down
Loading