Skip to content

Commit

Permalink
Enabling .NET 9 tests for SF SDK packages (#124)
Browse files Browse the repository at this point in the history
This PR enables tests for .NET 9 builds. 

Additionally, we are moving away from the `buils.ps1` script, which uses
`msbuild` under the hood. Instead, we are moving to the `dotnet` tool,
in the aim of streamlining the build process and infrastructure. Tests for multiple target frameworks will be introduced in a future commit.

Internal ADO work item:
https://dev.azure.com/msazure/One/_workitems/edit/29603235
  • Loading branch information
plave0 authored Oct 10, 2024
1 parent 29ac250 commit 98460e1
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
6 changes: 5 additions & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,13 @@ jobs:
TEST_RESULT_DIR: drop\testresults
steps:
- uses: actions/checkout@v1
- name: Setup dotnet
uses: actions/setup-dotnet@v4
with:
dotnet-version: '9.0.x'
- name: Build Everything
shell: powershell
run: ./build.ps1
run: dotnet build buildAll.proj
- name: Run Tests
run: dotnet test code.sln --configuration release --nologo --settings test\unittests\default.runsettings --results-directory ${{ env.TEST_RESULT_DIR }} --logger trx
- name: upload artifacts
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<PropertyGroup>
<AssemblyName>Microsoft.ServiceFabric.AspNetCore.Tests</AssemblyName>
<RootNamespace>Microsoft.ServiceFabric.AspNetCore.Tests</RootNamespace>
<TargetFramework>net8.0</TargetFramework>
<TargetFramework>net9.0</TargetFramework>
<DocumentationFile>$(OutputPath)\$(AssemblyName).xml</DocumentationFile>
</PropertyGroup>
<ItemGroup>
Expand Down

0 comments on commit 98460e1

Please sign in to comment.