Python: Adds a memory connector for Azure Cosmos DB for NoSQL #6195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
python
|
Need to update the pyproject.toml and poetry.lock file once the new version is released for azure-cosmos |
…/semantic-kernel into users/akataria/CosmosDB-NoSql
|
@moonbox3 , can you please review this PR as priority, we need this to be merged by this Friday for the Build Conference. The python SDK will be released today EOD, and I will update the azure-cosmos dependency accordingly. I have tested the functionality in my local, where it works correctly. |
@aayush3011 Yes, I will review first thing in the morning. Tagging @eavanvalkenburg if he can look during his morning, too, which is before mine. |
|
@aayush3011 you need to run |
eavanvalkenburg
requested changes
May 16, 2024
python/tests/integration/connectors/memory/test_azure_cosmosdb_no_sql_memory_store.py
Outdated
Show resolved
Hide resolved
moonbox3
reviewed
May 16, 2024
...emantic_kernel/connectors/memory/azure_cosmosdb_no_sql/azure_cosmosdb_no_sql_memory_store.py
Show resolved
Hide resolved
moonbox3
requested changes
May 16, 2024
...emantic_kernel/connectors/memory/azure_cosmosdb_no_sql/azure_cosmosdb_no_sql_memory_store.py
Outdated
Show resolved
Hide resolved
Python 3.10 Test Coverage Report •
Python 3.10 Unit Test Overview
|
|
@moonbox3 @eavanvalkenburg Please review again, once you get a chance. |
moonbox3
reviewed
May 16, 2024
moonbox3
reviewed
May 16, 2024
python/tests/integration/connectors/memory/test_azure_cosmosdb_no_sql_memory_store.py
Show resolved
Hide resolved
moonbox3
reviewed
May 17, 2024
…/semantic-kernel into users/akataria/CosmosDB-NoSql
moonbox3
approved these changes
May 17, 2024
moonbox3
approved these changes
May 17, 2024
eavanvalkenburg
approved these changes
May 17, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Unfortunately the new integration tests for this integration were not updated for the new function names, please have a look @aayush3011 |
…/semantic-kernel into users/akataria/CosmosDB-NoSql
moonbox3
approved these changes
May 17, 2024
…/semantic-kernel into users/akataria/CosmosDB-NoSql
auto-merge was automatically disabled
May 17, 2024 22:31
Head branch was pushed to by a user without write access
moonbox3
approved these changes
May 17, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
…/semantic-kernel into users/akataria/CosmosDB-NoSql
moonbox3
approved these changes
May 18, 2024
LudoCorporateShark
pushed a commit
to LudoCorporateShark/semantic-kernel
that referenced
this pull request
Aug 25, 2024
…oft#6195) ### Motivation and Context Azure Cosmos DB is adding Vector Similarity APIs to the NoSQL project, and would like Semantic Kernel users to be able to leverage them. This adds a Memory Connector implementation for Azure Cosmos DB's, including support for the new vector search functionality coming soon in Cosmos DB. <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 --------- Co-authored-by: Eduard van Valkenburg <[email protected]> Co-authored-by: Evan Mattson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Azure Cosmos DB is adding Vector Similarity APIs to the NoSQL project, and would like Semantic Kernel users to be able to leverage them.
This adds a Memory Connector implementation for Azure Cosmos DB's, including support for the new vector search functionality coming soon in Cosmos DB.
Description
Contribution Checklist