.Net: Rename method and class names to use Plugin instead of Skill #2945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed the method ImportSemanticSkillFromDirectory to ImportSemanticPluginFromDirectory and updated the Obsolete attribute message to reflect the change.
|
/sk generate-pr-description |
shawncal
added
.NET
github-actions
bot
changed the title
github-actions
bot
changed the title
|
Generate PR Description: succeeded ✅ |
lemillermicrosoft
changed the title
| @@ -118,7 +118,7 @@ public static class KernelSemanticFunctionExtensions | |||
| return kernel.RunAsync(skfunction); | |||
| } | |||
|
|
|||
| [Obsolete("Methods and classes which isnclud Skill in the name have been renamed to use Plugin. Use Kernel.ImportSemanticFunctionsFromDirectory instead. This will be removed in a future release.")] | |||
| [Obsolete("Methods and classes which isnclud Skill in the name have been renamed to use Plugin. Use Kernel.ImportSemanticPluginFromDirectory instead. This will be removed in a future release.")] | |||
There was a problem hiding this comment.
@lemillermicrosoft I was chatting with Matthew last night and he has requested we use the ImportSemanticFunctionsFromDirectory naming. So this PR will be superseded by this PR #2937.
auto-merge was automatically disabled
September 22, 2023 17:36
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request renames methods and classes that include Skill in their name to use Plugin instead. The deprecated method ImportSemanticSkillFromDirectory has been replaced with ImportSemanticPluginFromDirectory. This change is intended to improve consistency and clarity in the codebase.
Changes
Powered by Microsoft Semantic Kernel