Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: update GoogleConnector settings arg to search_api_key from api_key #10560

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Python: update GoogleConnector settings arg to search_api_key from api_key #10560

merged 1 commit into from
Feb 18, 2025

Conversation

moonbox3
Copy link
Contributor

Motivation and Context

The GoogleSearchSettings used for the GoogleConnector class use search_api_key instead of api_key.

Description

Fix the input argument, search_api_key, for the GoogleConnector class.

Contribution Checklist

@moonbox3 moonbox3 requested a review from a team as a code owner February 17, 2025 04:17
@moonbox3 moonbox3 enabled auto-merge February 17, 2025 04:17
@markwallace-microsoft markwallace-microsoft added the python Pull requests for the Python Semantic Kernel label Feb 17, 2025
@moonbox3 moonbox3 changed the title Python: update google_connector arg to search_api_key from api_key Python: update GoogleConnector settings arg to search_api_key from api_key Feb 17, 2025
@markwallace-microsoft
Copy link
Member

Python Test Coverage

Python Test Coverage Report •
FileStmtsMissCoverMissing
TOTAL18781223088% 
report-only-changed-files is enabled. No files were changed during this commit :)

Python Unit Test Overview

Tests Skipped Failures Errors Time
3200 5 💤 0 ❌ 0 🔥 1m 29s ⏱️

@moonbox3 moonbox3 added this pull request to the merge queue Feb 18, 2025
Merged via the queue into microsoft:main with commit 971a742 Feb 18, 2025
30 checks passed
@moonbox3 moonbox3 deleted the fix-google-search-api-key-arg branch February 18, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TaoChenOSU TaoChenOSU TaoChenOSU approved these changes

@eavanvalkenburg eavanvalkenburg eavanvalkenburg approved these changes

Assignees
No one assigned
Labels
python Pull requests for the Python Semantic Kernel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@moonbox3 @markwallace-microsoft @TaoChenOSU @eavanvalkenburg