-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: Remove OpenAI plugin. Update OpenAPI exec params to use direct predicate reference #10095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
the
python
Pull requests for the Python Semantic Kernel
label
Jan 6, 2025
Python Test Coverage Report •
Python Unit Test Overview
|
TaoChenOSU
approved these changes
Jan 6, 2025
Question: This is a breaking change since we are removing features. Are we ok with breaking changes now? |
Valid question, but I would say yes because of two reasons:
|
…ernel into py-openapi-param-fix
eavanvalkenburg
approved these changes
Jan 7, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 7, 2025
alliscode
approved these changes
Jan 7, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 7, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 7, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 7, 2025
TaoChenOSU
approved these changes
Jan 7, 2025
alliscode
approved these changes
Jan 7, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Dotnet had long removed the OpenAI plugin from its code base, and Python did not follow at the time. We had previously provided deprecation messages around using the OpenAI plugin and to switch to the OpenAPI plugin. We are now removing the OpenAI plugin from the SK Python SDK.
Additionally, there was a forward reference created without specifying the direct predicate context reference in the OpenAPIFunctionExecutionParameters. This put the burden on the dev to have to perform a model rebuild once the import was added. This PR cleans up the
OperationSelectionPredicateContext
import, which is now direct and via the sub-module and not via the parent module, which causes the init.py to load all dependencies (which is unnecessary).Description
This PR:
OperationSelectionPredicateContext
import to allow a user to create the func exec params without receiving a pydantic error.Contribution Checklist