Add interface pin, split IConfiguration to be non-breaking #919
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR started by adding the
InterfaceConcretionTests
class, which includes concrete versions of all of the interfaces that I was able to identify as being exposed in the 3.0.1 version of the API. Ideally, these should also cover the data types that are in the API interface, but that's for another PR. These interface versions were based on the commit that shipped in release 3.0.1, then added to the current bits in main--thePinnedIConfiguration
class broke, which is what flagged the fact that we had accidentally broken theIConfiguration class
in #773, which added theLicenseInformationTimeoutInSeconds
property to theIConfiguration
interface.The proposed fix is to move the new
LicenseInformationTimeoutInSeconds
property into theIConfiguration2
interface, which derives fromIConfiguration
. It then makes theInputConfiguration
class derive fromIConfiguration2
and updates the usages ofLicenseInformationTimeoutInSeconds
so that we get there via theIConfiguration2
interface.