Update metadata contract to be backcompatible with SPDX 2.2 parser #918
Conversation
There was a problem hiding this comment.
The one other place we will need to change is SbomParser, which references SpdxMetadata right now in the GetMetadata method, making it not backwards compatible. Depending on how permanent we want these changes to be, we could do this by making ISbomParser generic depending on metadata type, or we can just temporarily revert it to only use the 2.2 metadata version
Would you mind linking which file you're referring to? I looked through all the references of GetMetadata and it seems right to me |
|
Yeah, this is where I think we need an update: https://github.com/microsoft/sbom-tool/blob/main/src/Microsoft.Sbom.Parsers.Spdx22SbomParser/Parser/SPDXParser.cs#L175. DM'ed you to discuss this break in more detail :) |
|
/azp run |
The metadata class name was updated in an earlier PR (https://github.com/microsoft/sbom-tool/pull/860/files) which was a breaking change for consumers of the SPDX 2.2 parser. We are introducing this change to allow for backwards compatibility with the SPDX 2.2 parser and compatibility with the SPDX 3.0 parser.