Sidestep a timing issue with the TaskLoggingHelper in the GenerateSbomTask's Logging infrastructure #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mTask's Logging infrastructure Also generate binlogs for the tests to allow precise investigation of the builds
baronfel
requested review from
JoseRenan and
jlperkins
and removed request for
a team
sfoslund
reviewed
Oct 1, 2024
| Assert.IsTrue(pack, "Failed to pack the project"); | ||
| } | ||
|
|
||
| // binlogs are unique per name, so this ensures distinct names for the different stages | ||
| private BinaryLogger GetBinLog(string callerName, string target) => new BinaryLogger { Parameters = $"{callerName}.{target}.binlog" }; |
There was a problem hiding this comment.
I assume these changes are just for debugging purposes and not actually necessary?
There was a problem hiding this comment.
exactly - needed to see what was failing in the tests in a stable way, and the binlog viewer helps a ton with figuring out why the specific build failed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.