Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify validate -o argument description #567

Merged
merged 2 commits into from
May 6, 2024

Conversation

alisonlomaka
Copy link
Member

Clarify the README description of validate argument -o; this argument requires a path with file name, not just path. The error when it doesn't get one is Access Denied, which is not very helpful.

… requires a path with file name, not just path. The error when it doesn't get one is Access Denied, which is not very helpful.
@alisonlomaka alisonlomaka requested a review from a team as a code owner May 6, 2024 16:08
Copy link
Member

@sfoslund sfoslund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sorry, CI appears to be broken right now so you'll have to rerun once #568 has been merged

@codecov-commenter
Copy link

codecov-commenter commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.41%. Comparing base (947bb26) to head (d1250c2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #567   +/-   ##
=======================================
  Coverage   58.41%   58.41%           
=======================================
  Files         250      250           
  Lines        7796     7796           
  Branches      916      916           
=======================================
  Hits         4554     4554           
  Misses       2826     2826           
  Partials      416      416           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alisonlomaka alisonlomaka merged commit 53f7508 into main May 6, 2024
6 checks passed
@alisonlomaka alisonlomaka deleted the alisonl/clarifyValidatorArgsReadme branch May 6, 2024 16:53
tarun06 pushed a commit to tarun06/sbom-tool that referenced this pull request Jul 21, 2024
… requires a path with file name, not just path. The error when it doesn't get one is Access Denied, which is not very helpful. (microsoft#567)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants