Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix style errors in build #521

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Fix style errors in build #521

merged 1 commit into from
Mar 7, 2024

Conversation

pownkel
Copy link
Contributor

@pownkel pownkel commented Mar 7, 2024

Last month, a regression in the dotnet SDK caused our builds to start breaking due to style errors that should have been silenced. This PR uses a known workaround (setting properties related to the failing style rules to true instead of true:warning. This will not interfere with the workflow described in #340 (i.e. removing the line dotnet_diagnostic.RULE_ID.severity = suggestion will re-enable the rule as expected).

This PR does silence one rule that was not previously silenced, because it refers to a language feature new to dotnet 8, and we build for both dotnet 8 and dotnet 6.

@pownkel pownkel requested a review from a team as a code owner March 7, 2024 00:52
@pownkel pownkel requested review from jlperkins and RobGallo March 7, 2024 00:52
@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.73%. Comparing base (ee3c4f5) to head (e9e40d1).
Report is 147 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #521   +/-   ##
=======================================
  Coverage   59.73%   59.73%           
=======================================
  Files         248      248           
  Lines        7572     7572           
  Branches      901      900    -1     
=======================================
  Hits         4523     4523           
  Misses       2637     2637           
  Partials      412      412           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pownkel pownkel merged commit 0196d27 into main Mar 7, 2024
6 checks passed
@pownkel pownkel deleted the pownkel/style-errors branch March 7, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants